Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ReactiveUI from XPlat templates #252

Closed
maxkatz6 opened this issue Mar 12, 2024 · 5 comments
Closed

Remove ReactiveUI from XPlat templates #252

maxkatz6 opened this issue Mar 12, 2024 · 5 comments

Comments

@maxkatz6
Copy link
Member

Is your feature request related to a problem? Please describe.

^

Describe the solution you'd like

Personally, I would go with no MVVM framework at all. Possibly just keep ViewModelBase with minimal INotifyPropertyChanged impl and link to our documentation explaining other possibilities

Describe alternatives you've considered

No response

Additional context

No response

@stevemonaco
Copy link

I understand the desire to be more like WPF that only offers the blankest of canvases, but that's pretty inconvenient for end developers. I would probably not use avalonia-dotnet-templates anymore and would either: 1. create my own template or 2. find a third-party template provider. I frequently create new Avalonia projects to experiment/verify and the 3-5 minute savings per project with Mvvm Toolkit out-of-the-box does add up. Once I get invested in reinventing part of the wheel, I'm probably reinventing the entire wheel.

@Mrxx99
Copy link
Contributor

Mrxx99 commented Apr 14, 2024

What about having no mvvm by default in xplat template, but an option (--usemvvm) to include Community toolkit MVVM?

@stevemonaco
Copy link

If the template option still generates and wires a basic Mvvm Toolkit app similar to today, then that's sufficient.

@maxkatz6
Copy link
Member Author

Having an additional option parameter makes sense, yes.
Even though It makes templates more complex.

@maxkatz6
Copy link
Member Author

It's not optional #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants