Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve ContentTypeSeo handling and breadcrumb generation #90

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix: improve ContentTypeSeo handling and breadcrumb generation #90

merged 1 commit into from
Apr 8, 2024

Conversation

justlevine
Copy link
Member

What

This PR:

  • Refactors breadcrumb generation so each Model handles its own generation.
  • Improves the handling of ContentTypeSeo to account for Post Archives.

Why

Fixes #81 in lieu of wp-graphql/wp-graphql#2491

How

Testing Instructions

Additional Info

Checklist:

  • My code is tested to the best of my abilities.
  • My code follows the WordPress Coding Standards.
  • My code has proper inline documentation.
  • I have added unit tests to verify the code works as intended.
  • The changes in this PR have been noted in CHANGELOG.md

@justlevine justlevine mentioned this pull request Apr 8, 2024
Closed
3 tasks
@justlevine justlevine merged commit 7d9ccec into AxeWP:develop Apr 8, 2024
23 of 25 checks passed
@justlevine justlevine deleted the fix/content-type-seo branch April 8, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

breadcrumb produce Internal server error on ContentType
1 participant
@justlevine