From 1213c2beb67d320e82e2ac79e41704e1f1dedd84 Mon Sep 17 00:00:00 2001 From: Jason Collins Date: Mon, 25 Sep 2023 14:25:01 -0700 Subject: [PATCH 1/5] ISSUE-143 - skip publishing of api when no spec found --- discovery/pkg/apigee/pollproxiesjob.go | 2 +- discovery/pkg/apigee/pollproxiesjob_test.go | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/discovery/pkg/apigee/pollproxiesjob.go b/discovery/pkg/apigee/pollproxiesjob.go index e8d29b0..d977489 100644 --- a/discovery/pkg/apigee/pollproxiesjob.go +++ b/discovery/pkg/apigee/pollproxiesjob.go @@ -396,7 +396,7 @@ func (j *pollProxiesJob) buildServiceBody(ctx context.Context) (*apic.ServiceBod } if len(spec) == 0 { - logger.Debug("creating without a spec") + return nil, fmt.Errorf("skipping proxy creation without a spec") } logger.Debug("creating service body") diff --git a/discovery/pkg/apigee/pollproxiesjob_test.go b/discovery/pkg/apigee/pollproxiesjob_test.go index 37544d1..d34d550 100644 --- a/discovery/pkg/apigee/pollproxiesjob_test.go +++ b/discovery/pkg/apigee/pollproxiesjob_test.go @@ -57,11 +57,10 @@ func Test_pollProxiesJob(t *testing.T) { hasOauth: true, }, { - name: "should create proxy when no spec found but has api key policy", - hasAPIKey: true, + name: "should create proxy when no spec found", }, { - name: "should create proxy when no spec found", + name: "should stop when no spec found but has api key policy", }, { name: "should stop when getting proxy revision fails", From b9f1c602dad9628ee592fea996ed265183b4681b Mon Sep 17 00:00:00 2001 From: Jason Collins Date: Mon, 25 Sep 2023 14:50:23 -0700 Subject: [PATCH 2/5] ISSUE-140 - updates for deprovisioning access requests --- discovery/pkg/apigee/provision.go | 34 ++++++++++++-------------- discovery/pkg/apigee/provision_test.go | 10 ++++---- 2 files changed, 21 insertions(+), 23 deletions(-) diff --git a/discovery/pkg/apigee/provision.go b/discovery/pkg/apigee/provision.go index 5ccd3f0..4cb1206 100644 --- a/discovery/pkg/apigee/provision.go +++ b/discovery/pkg/apigee/provision.go @@ -63,17 +63,21 @@ func NewProvisioner(client client, credExpDays int, cacheMan cacheManager, isPro } } +func getAPIProductName(apiID string, quota prov.Quota) string { + name := fmt.Sprintf("%s-no-quota", apiID) + if quota != nil { + name = fmt.Sprintf("%s-%s", apiID, quota.GetPlanName()) + } + return name +} + // AccessRequestDeprovision - removes an api from an application func (p provisioner) AccessRequestDeprovision(req prov.AccessRequest) prov.RequestStatus { instDetails := req.GetInstanceDetails() apiID := util.ToString(instDetails[defs.AttrExternalAPIID]) logger := p.logger.WithField("handler", "AccessRequestDeprovision").WithField("apiID", apiID).WithField("application", req.GetApplicationName()) - if p.isProductMode && req.GetQuota() != nil && req.GetQuota().GetPlanName() != "" { - // append the plan name to the apiID - apiID = fmt.Sprintf("%s-%s", apiID, req.GetQuota().GetPlanName()) - } - + apiProductName := getAPIProductName(apiID, req.GetQuota()) // remove link between api product and app logger.Info("deprovisioning access request") ps := prov.NewRequestStatusBuilder() @@ -101,10 +105,10 @@ func (p provisioner) AccessRequestDeprovision(req prov.AccessRequest) prov.Reque // find the credential that the api is linked to for _, c := range app.Credentials { for _, prod := range c.ApiProducts { - if prod.Apiproduct == apiID { + if prod.Apiproduct == apiProductName { cred = &c - err := p.client.UpdateCredentialProduct(appName, devID, cred.ConsumerKey, apiID, false) + err := p.client.UpdateCredentialProduct(appName, devID, cred.ConsumerKey, apiProductName, false) if err != nil { return failed(logger, ps, fmt.Errorf("failed to revoke api product %s from credential: %s", prod.Apiproduct, err)) } @@ -150,7 +154,7 @@ func (p provisioner) AccessRequestProvision(req prov.AccessRequest) (prov.Reques // get plan name from access request // get api product, or create new one - apiProductName := fmt.Sprintf("%s-%s", apiID, "no-quota") + apiProductName := getAPIProductName(apiID, req.GetQuota()) quota := "" quotaInterval := "1" quotaTimeUnit := "" @@ -172,25 +176,19 @@ func (p provisioner) AccessRequestProvision(req prov.AccessRequest) (prov.Reques default: return failed(logger, ps, fmt.Errorf("invalid quota time unit: received %s", q.GetIntervalString())), nil } - - apiProductName = fmt.Sprintf("%s-%s", apiID, req.GetQuota().GetPlanName()) } var product *models.ApiProduct + var err error if p.isProductMode { logger.Debug("handling for product mode") - var err error product, err = p.productModeCreateProduct(logger, apiProductName, apiID, quota, quotaInterval, quotaTimeUnit) - if err != nil { - return failed(logger, ps, fmt.Errorf("failed to create api product: %s", err)), nil - } } else { logger.Debug("handling for proxy mode") - var err error product, err = p.proxyModeCreateProduct(logger, apiProductName, apiID, stage, quota, quotaInterval, quotaTimeUnit) - if err != nil { - return failed(logger, ps, fmt.Errorf("failed to create api product: %s", err)), nil - } + } + if err != nil { + return failed(logger, ps, fmt.Errorf("failed to create api product: %s", err)), nil } app, err := p.client.GetDeveloperApp(appName) diff --git a/discovery/pkg/apigee/provision_test.go b/discovery/pkg/apigee/provision_test.go index ef00583..17e15cf 100644 --- a/discovery/pkg/apigee/provision_test.go +++ b/discovery/pkg/apigee/provision_test.go @@ -76,7 +76,7 @@ func TestAccessRequestDeprovision(t *testing.T) { for _, tc := range tests { t.Run(tc.name, func(t *testing.T) { - app := newApp(tc.apiID, tc.appName) + app := newApp(fmt.Sprintf("%s-no-quota", tc.apiID), tc.appName) p := NewProvisioner(&mockClient{ t: t, @@ -86,7 +86,7 @@ func TestAccessRequestDeprovision(t *testing.T) { app: app, appName: tc.appName, key: app.Credentials[0].ConsumerKey, - productName: tc.apiID, + productName: fmt.Sprintf("%s-no-quota", tc.apiID), }, 30, &mockCache{t: t}, false, false) if tc.missingCred { @@ -735,7 +735,7 @@ func (m mockClient) UpdateDeveloperApp(app models.DeveloperApp) (*models.Develop return nil, nil } -func newApp(apiID string, appName string) *models.DeveloperApp { +func newApp(productName string, appName string) *models.DeveloperApp { cred := &models.DeveloperApp{ Credentials: []models.DeveloperAppCredentials{ { @@ -747,10 +747,10 @@ func newApp(apiID string, appName string) *models.DeveloperApp { Name: appName, } - if apiID != "" { + if productName != "" { cred.Credentials[0].ApiProducts = []models.ApiProductRef{ { - Apiproduct: apiID, + Apiproduct: productName, }, } } From aacd207825d115691a705758c8f84269df7f74c1 Mon Sep 17 00:00:00 2001 From: Jason Collins Date: Mon, 25 Sep 2023 15:28:50 -0700 Subject: [PATCH 3/5] ISSUE-146 in use a mutex before writing to or reading spec map --- discovery/pkg/apigee/cache.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/discovery/pkg/apigee/cache.go b/discovery/pkg/apigee/cache.go index 9cc61e7..f57d1fc 100644 --- a/discovery/pkg/apigee/cache.go +++ b/discovery/pkg/apigee/cache.go @@ -3,6 +3,7 @@ package apigee import ( "fmt" "strings" + "sync" "time" "github.com/Axway/agent-sdk/pkg/apic" @@ -12,6 +13,7 @@ import ( type agentCache struct { cache cache.Cache specEndpointToKeys map[string][]specCacheItem + mutex *sync.Mutex } type specCacheItem struct { @@ -25,6 +27,7 @@ func newAgentCache() *agentCache { return &agentCache{ cache: cache.New(), specEndpointToKeys: make(map[string][]specCacheItem), + mutex: &sync.Mutex{}, } } @@ -43,6 +46,8 @@ func (a *agentCache) AddSpecToCache(id, path, name string, modDate time.Time, en a.cache.SetWithSecondaryKey(specPrimaryKey(name), path, item) a.cache.SetSecondaryKey(specPrimaryKey(name), strings.ToLower(name)) a.cache.SetSecondaryKey(specPrimaryKey(name), id) + a.mutex.Lock() + defer a.mutex.Unlock() for _, ep := range endpoints { if _, found := a.specEndpointToKeys[ep]; !found { a.specEndpointToKeys[ep] = []specCacheItem{} @@ -90,6 +95,8 @@ func (a *agentCache) GetSpecWithName(name string) (*specCacheItem, error) { // GetSpecPathWithEndpoint - returns the lat modified spec found with this endpoint func (a *agentCache) GetSpecPathWithEndpoint(endpoint string) (string, error) { + a.mutex.Lock() + defer a.mutex.Unlock() items, found := a.specEndpointToKeys[endpoint] if !found { return "", fmt.Errorf("no spec found for endpoint: %s", endpoint) From 154587816b53c597afe0fdd3db69bfe0fec3b8f4 Mon Sep 17 00:00:00 2001 From: Jason Collins Date: Tue, 26 Sep 2023 09:04:10 -0700 Subject: [PATCH 4/5] ISSUE-142 - gen url from bundle proxy config file --- client/pkg/apigee/models/model_ssl_info.go | 2 +- client/pkg/apigee/proxy.go | 63 ++++++++++++++++- client/scripts/apigee_generate.sh | 1 + client/scripts/model_ssl_info.tmpl | 22 ++++++ discovery/pkg/apigee/pollproxiesjob.go | 78 ++++++++++++++------- discovery/pkg/apigee/pollproxiesjob_test.go | 4 ++ discovery/pkg/apigee/util.go | 4 +- 7 files changed, 142 insertions(+), 32 deletions(-) create mode 100644 client/scripts/model_ssl_info.tmpl diff --git a/client/pkg/apigee/models/model_ssl_info.go b/client/pkg/apigee/models/model_ssl_info.go index 5d1c676..2d82205 100644 --- a/client/pkg/apigee/models/model_ssl_info.go +++ b/client/pkg/apigee/models/model_ssl_info.go @@ -18,7 +18,7 @@ type SslInfo struct { // Flag that specifies whether to enable one-way TLS/SSL. You must have defined a keystore containing the cert and private key. **For Edge for Public Cloud**: * You must have a cert signed by a trusted entity, such as Symantec or VeriSign. You cannot use a self-signed cert, or leaf certificates signed by a self-signed CA. * If your existing virtual host is configured to use a port other than `443`, you cannot change the TLS setting. That means you cannot change the TLS setting from enabled to disabled, or from disabled to enabled. Enabled string `json:"enabled,omitempty"` // Flag that specifies whether to ignore TLS certificate errors. This is similar to the `-k` option to curl. This option is valid when configuring TLS for Target Servers and Target Endpoints, and when configuring virtual hosts that use 2-way TLS. When used with a target endpoint/target server, if the backend system uses SNI and returns a cert with a subject Distinguished Name (DN) that does not match the hostname, there is no way to ignore the error and the connection fails. - IgnoreValidationErrors string `json:"ignoreValidationErrors,omitempty"` + IgnoreValidationErrors bool `json:"ignoreValidationErrors,omitempty"` // Alias specified when you uploaded the cert and private key to the keystore. You must specify the alias name literally; you cannot use a reference. See Options for configuring TLS for more. KeyAlias string `json:"keyAlias,omitempty"` // Name of the keystore on Edge. Apigee recommends that you use a reference to specify the keystore name so that you can change the keystore without having to restart Routers. See Options for configuring TLS for more. diff --git a/client/pkg/apigee/proxy.go b/client/pkg/apigee/proxy.go index b04740a..7c323e0 100644 --- a/client/pkg/apigee/proxy.go +++ b/client/pkg/apigee/proxy.go @@ -1,13 +1,30 @@ package apigee import ( + "archive/zip" + "bytes" "encoding/json" + "encoding/xml" "fmt" + "io" "net/http" "github.com/Axway/agents-apigee/client/pkg/apigee/models" ) +// proxyXML +type proxyXML struct { + XMLName xml.Name `xml:"ProxyEndpoint"` + HTTPProxyConnection *HTTPProxyConnection `xml:"HTTPProxyConnection"` +} + +// HTTPProxyConnection +type HTTPProxyConnection struct { + XMLName xml.Name `xml:"HTTPProxyConnection"` + BasePath string `xml:"BasePath"` + VirtualHost string `xml:"VirtualHost"` +} + // Products type Proxies []string @@ -47,7 +64,7 @@ func (a *ApigeeClient) GetProxy(proxyName string) (*models.ApiProxy, error) { return proxy, nil } -// GetProxy - get a proxy with a name +// GetRevision - get a revision of a proxy with a name func (a *ApigeeClient) GetRevision(proxyName, revision string) (*models.ApiProxyRevision, error) { response, err := a.newRequest(http.MethodGet, fmt.Sprintf("%s/apis/%s/revisions/%s", a.orgURL, proxyName, revision), WithDefaultHeaders(), @@ -65,6 +82,50 @@ func (a *ApigeeClient) GetRevision(proxyName, revision string) (*models.ApiProxy return proxyRevision, nil } +// GetRevisionBundle - get a revision bundle of a proxy with a name +func (a *ApigeeClient) GetRevisionConnectionType(proxyName, revision string) (*HTTPProxyConnection, error) { + response, err := a.newRequest(http.MethodGet, fmt.Sprintf("%s/apis/%s/revisions/%s", a.orgURL, proxyName, revision), + WithDefaultHeaders(), + WithQueryParam("format", "bundle"), + ).Execute() + if err != nil { + return nil, err + } + + // response is a zip file, lets + zipReader, err := zip.NewReader(bytes.NewReader(response.Body), int64(len(response.Body))) + if err != nil { + return nil, err + } + + // Read all the files from the zip archive + var fileBytes []byte + for _, zipFile := range zipReader.File { + if zipFile.Name != "apiproxy/proxies/default.xml" { + continue + } + fileBytes, err = readZipFile(zipFile) + if err != nil { + return nil, err + } + break + } + + data := &proxyXML{} + xml.Unmarshal(fileBytes, data) + + return data.HTTPProxyConnection, nil +} + +func readZipFile(zf *zip.File) ([]byte, error) { + f, err := zf.Open() + if err != nil { + return nil, err + } + defer f.Close() + return io.ReadAll(f) +} + // GetProxy - get a proxy with a name func (a *ApigeeClient) GetRevisionResourceFile(proxyName, revision, resourceType, resourceName string) ([]byte, error) { response, err := a.newRequest(http.MethodGet, fmt.Sprintf("%s/apis/%s/revisions/%s/resourcefiles/%s/%s", a.orgURL, proxyName, revision, resourceType, resourceName), diff --git a/client/scripts/apigee_generate.sh b/client/scripts/apigee_generate.sh index fa02a96..9e03720 100755 --- a/client/scripts/apigee_generate.sh +++ b/client/scripts/apigee_generate.sh @@ -22,5 +22,6 @@ sed -i -r 's/Timestamp.string/Timestamp int64/g' /codegen/output/model_metrics_v # replace the model_metrics_metrics.go file with the template for the custom unmarshal cp ./model_metrics_metrics.tmpl /codegen/output/model_metrics_metrics.go cp ./model_virtual_host.tmpl /codegen/output/model_virtual_host.go +cp ./model_ssl_info.tmpl /codegen/output/model_ssl_info.go rm ./openapitools.json \ No newline at end of file diff --git a/client/scripts/model_ssl_info.tmpl b/client/scripts/model_ssl_info.tmpl new file mode 100644 index 0000000..8b32a2d --- /dev/null +++ b/client/scripts/model_ssl_info.tmpl @@ -0,0 +1,22 @@ +// Modified after generation +package models + +// SslInfo SSL information. +type SslInfo struct { + // **Edge for Private Cloud version 4.15.07 and earlier only.** Specifies the ciphers supported by the virtual host. If no ciphers are specified, then all ciphers available for the JVM will be permitted. To restrict ciphers, add the following elements: `TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA` and `TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256` + Ciphers []string `json:"ciphers,omitempty"` + // Flag that specifies whether to enable two-way, or client, TLS between Edge (server) and the app (client) making the request. Enabling two-way TLS requires that you set up a truststore on Edge that contains the cert from the TLS client. + ClientAuthEnabled string `json:"clientAuthEnabled,omitempty"` + // Flag that specifies whether to enable one-way TLS/SSL. You must have defined a keystore containing the cert and private key. **For Edge for Public Cloud**: * You must have a cert signed by a trusted entity, such as Symantec or VeriSign. You cannot use a self-signed cert, or leaf certificates signed by a self-signed CA. * If your existing virtual host is configured to use a port other than `443`, you cannot change the TLS setting. That means you cannot change the TLS setting from enabled to disabled, or from disabled to enabled. + Enabled string `json:"enabled,omitempty"` + // Flag that specifies whether to ignore TLS certificate errors. This is similar to the `-k` option to curl. This option is valid when configuring TLS for Target Servers and Target Endpoints, and when configuring virtual hosts that use 2-way TLS. When used with a target endpoint/target server, if the backend system uses SNI and returns a cert with a subject Distinguished Name (DN) that does not match the hostname, there is no way to ignore the error and the connection fails. + IgnoreValidationErrors bool `json:"ignoreValidationErrors,omitempty"` + // Alias specified when you uploaded the cert and private key to the keystore. You must specify the alias name literally; you cannot use a reference. See Options for configuring TLS for more. + KeyAlias string `json:"keyAlias,omitempty"` + // Name of the keystore on Edge. Apigee recommends that you use a reference to specify the keystore name so that you can change the keystore without having to restart Routers. See Options for configuring TLS for more. + KeyStore string `json:"keyStore,omitempty"` + // **Edge for Private Cloud version 4.15.07 and earlier only.** Specifies the protocols supported by the virtual host. If no protocols are specified, then all protocols available for the JVM will be permitted. To restrict protocols, add the following elements: `TLSv1`, `TLSv1.2`, and `SSLv2Hello` + Protocols []string `json:"protocols,omitempty"` + // Name of the truststore on Edge that contains the certificate or certificate chain used for two-way TLS. Required if `clientAuthEnabled` is `true`. Apigee recommends that you use a reference to specify the truststore name so that you can change the truststore without having to restart Routers. See Options for configuring TLS for more. + TrustStore string `json:"trustStore,omitempty"` +} diff --git a/discovery/pkg/apigee/pollproxiesjob.go b/discovery/pkg/apigee/pollproxiesjob.go index d977489..f23ec72 100644 --- a/discovery/pkg/apigee/pollproxiesjob.go +++ b/discovery/pkg/apigee/pollproxiesjob.go @@ -35,6 +35,7 @@ type proxyClient interface { GetAllProxies() (apigee.Proxies, error) GetRevision(proxyName, revision string) (*models.ApiProxyRevision, error) GetRevisionResourceFile(proxyName, revision, resourceType, resourceName string) ([]byte, error) + GetRevisionConnectionType(proxyName, revision string) (*apigee.HTTPProxyConnection, error) GetDeployments(apiName string) (*models.DeploymentDetails, error) GetVirtualHost(envName, virtualHostName string) (*models.VirtualHost, error) GetSpecFile(specPath string) ([]byte, error) @@ -52,28 +53,32 @@ type proxyCache interface { // job that will poll for any new portals on APIGEE Edge type pollProxiesJob struct { jobs.Job - client proxyClient - cache proxyCache - firstRun bool - logger log.FieldLogger - specsReady jobFirstRunDone - pubLock sync.Mutex - publishFunc agent.PublishAPIFunc - workers int - running bool - runningLock sync.Mutex + client proxyClient + cache proxyCache + firstRun bool + logger log.FieldLogger + specsReady jobFirstRunDone + pubLock sync.Mutex + publishFunc agent.PublishAPIFunc + workers int + running bool + runningLock sync.Mutex + virtualHostURLs map[string]map[string][]string + lastTime int + runTime int } func newPollProxiesJob(client proxyClient, cache proxyCache, specsReady jobFirstRunDone, workers int) *pollProxiesJob { job := &pollProxiesJob{ - client: client, - cache: cache, - firstRun: true, - specsReady: specsReady, - logger: log.NewFieldLogger().WithComponent("pollProxies").WithPackage("apigee"), - publishFunc: agent.PublishAPI, - workers: workers, - runningLock: sync.Mutex{}, + client: client, + cache: cache, + firstRun: true, + specsReady: specsReady, + logger: log.NewFieldLogger().WithComponent("pollProxies").WithPackage("apigee"), + publishFunc: agent.PublishAPI, + workers: workers, + runningLock: sync.Mutex{}, + virtualHostURLs: make(map[string]map[string][]string), } return job } @@ -131,6 +136,7 @@ func (j *pollProxiesJob) Execute() error { wg := sync.WaitGroup{} wg.Add(len(allProxies)) + j.runTime = j.lastTime for _, proxyName := range allProxies { go func() { defer wg.Done() @@ -202,6 +208,13 @@ func (j *pollProxiesJob) handleRevision(ctx context.Context, revName string) { return } + if revision.LastModifiedAt <= j.runTime { + return + } + if j.lastTime < revision.LastModifiedAt { + j.lastTime = revision.LastModifiedAt + } + ctx = context.WithValue(ctx, revNameField, revision) logger = logger.WithField(revNameField.String(), revision.Revision) addLoggerToContext(ctx, logger) @@ -275,18 +288,29 @@ func (j *pollProxiesJob) getVirtualHostURLs(ctx context.Context) context.Context revision := ctx.Value(revNameField).(*models.ApiProxyRevision) envName := getStringFromContext(ctx, envNameField) proxyName := getStringFromContext(ctx, proxyNameField) - - // attempt to get the spec from the endpoints the revision is hosted on allURLs := []string{} - for _, virtualHostName := range revision.Proxies { - logger := logger.WithField("virtualHostName", virtualHostName) - virtualHost, err := j.client.GetVirtualHost(envName, virtualHostName) + + connection, err := j.client.GetRevisionConnectionType(proxyName, revision.Revision) + if err != nil { + logger.WithError(err).Error("could not get the revision connection type") + return context.WithValue(ctx, endpointsField, allURLs) + } + + if _, ok := j.virtualHostURLs[envName]; !ok { + j.virtualHostURLs[envName] = make(map[string][]string) + } + + if _, ok := j.virtualHostURLs[envName][connection.VirtualHost]; !ok { + virtualHost, err := j.client.GetVirtualHost(envName, connection.VirtualHost) if err != nil { - logger.WithError(err).Debug("could not get virtual host details") - continue + logger.WithError(err).Error("could not get the virtual host info") + return context.WithValue(ctx, endpointsField, allURLs) } - urls := urlsFromVirtualHost(virtualHost, proxyName) - allURLs = append(allURLs, urls...) + j.virtualHostURLs[envName][connection.VirtualHost] = urlsFromVirtualHost(virtualHost) + } + + for _, url := range j.virtualHostURLs[envName][connection.VirtualHost] { + allURLs = append(allURLs, fmt.Sprintf("%s%s", url, connection.BasePath)) } return context.WithValue(ctx, endpointsField, allURLs) diff --git a/discovery/pkg/apigee/pollproxiesjob_test.go b/discovery/pkg/apigee/pollproxiesjob_test.go index d34d550..977b20f 100644 --- a/discovery/pkg/apigee/pollproxiesjob_test.go +++ b/discovery/pkg/apigee/pollproxiesjob_test.go @@ -205,6 +205,10 @@ func (m mockProxyClient) GetRevision(apiName, revision string) (rev *models.ApiP return } +func (m mockProxyClient) GetRevisionConnectionType(proxyName, revision string) (*apigee.HTTPProxyConnection, error) { + return nil, nil +} + func (m mockProxyClient) GetRevisionResourceFile(apiName, revision, resourceType, resourceName string) ([]byte, error) { assert.Contains(m.t, proxyName, apiName) assert.Contains(m.t, revName, revision) diff --git a/discovery/pkg/apigee/util.go b/discovery/pkg/apigee/util.go index 7a8944e..50f76b9 100644 --- a/discovery/pkg/apigee/util.go +++ b/discovery/pkg/apigee/util.go @@ -5,7 +5,6 @@ import ( "fmt" "net/url" "strconv" - "strings" "github.com/Axway/agent-sdk/pkg/apic" "github.com/Axway/agent-sdk/pkg/util/log" @@ -20,7 +19,7 @@ func isFullURL(urlString string) bool { return false } -func urlsFromVirtualHost(virtualHost *models.VirtualHost, proxyName string) []string { +func urlsFromVirtualHost(virtualHost *models.VirtualHost) []string { urls := []string{} scheme := "http" @@ -43,7 +42,6 @@ func urlsFromVirtualHost(virtualHost *models.VirtualHost, proxyName string) []st if virtualHost.BaseUrl != "/" { thisURL += virtualHost.BaseUrl } - thisURL += "/" + strings.ToLower(proxyName) urls = append(urls, thisURL) } From adda30aee54856243e925526cf5e3ac0873c55ec Mon Sep 17 00:00:00 2001 From: Jason Collins Date: Tue, 26 Sep 2023 09:49:15 -0700 Subject: [PATCH 5/5] code review comments --- client/pkg/apigee/proxy.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/client/pkg/apigee/proxy.go b/client/pkg/apigee/proxy.go index 7c323e0..36a8008 100644 --- a/client/pkg/apigee/proxy.go +++ b/client/pkg/apigee/proxy.go @@ -82,7 +82,7 @@ func (a *ApigeeClient) GetRevision(proxyName, revision string) (*models.ApiProxy return proxyRevision, nil } -// GetRevisionBundle - get a revision bundle of a proxy with a name +// GetRevisionConnectionType - get a revision bundle and open the proxy config file func (a *ApigeeClient) GetRevisionConnectionType(proxyName, revision string) (*HTTPProxyConnection, error) { response, err := a.newRequest(http.MethodGet, fmt.Sprintf("%s/apis/%s/revisions/%s", a.orgURL, proxyName, revision), WithDefaultHeaders(), @@ -92,7 +92,7 @@ func (a *ApigeeClient) GetRevisionConnectionType(proxyName, revision string) (*H return nil, err } - // response is a zip file, lets + // response is a zip file, lets open it and find the proxy config file zipReader, err := zip.NewReader(bytes.NewReader(response.Body), int64(len(response.Body))) if err != nil { return nil, err @@ -111,6 +111,10 @@ func (a *ApigeeClient) GetRevisionConnectionType(proxyName, revision string) (*H break } + if len(fileBytes) == 0 { + return nil, fmt.Errorf("could not find the proxy configuration file in the api revision bundle") + } + data := &proxyXML{} xml.Unmarshal(fileBytes, data)