Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aztec-nr is breaking unsafe block rules #11087

Closed
TomAFrench opened this issue Jan 7, 2025 · 1 comment · Fixed by #11094
Closed

aztec-nr is breaking unsafe block rules #11087

TomAFrench opened this issue Jan 7, 2025 · 1 comment · Fixed by #11094
Assignees
@benesjan

Comments

@TomAFrench
Copy link
Member

aztec-nr is calling unconstrained functions outside of unsafe blocks. This is being converted into an error at which point this will no longer compile.

https://github.com/noir-lang/noir/actions/runs/12652898501/job/35256807896?pr=6938
@benesjan benesjan assigned benesjan and unassigned nventuro, benesjan and Thunkar Jan 7, 2025
@benesjan benesjan mentioned this issue Jan 7, 2025
Merged
nventuro pushed a commit that referenced this issue Jan 15, 2025
@benesjan @spalladino
chore: fixing @safety warnings (#11094)
5de24e0 
Fixes #11087

## Note for reviewer
I originally addressed a bunch of other stuff in this PR but as
@nventuro pointed out it became too messy so I separated those changes
into a PR up the stack.

~**Merging currently blocked by** [this nargo fmt
bug](noir-lang/noir#7045

---------

Co-authored-by: Santiago Palladino <[email protected]>
@benesjan benesjan mentioned this issue Jan 15, 2025
Open
@benesjan
Copy link
Contributor

Created a follow-up issue for warnings in protocol circuits #11251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fixing @safety warnings AztecProtocol/aztec-packages
4 participants
@nventuro @Thunkar @benesjan @TomAFrench