Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Aztec.nr): Remove the open keyword, in favour of the public attribute #1886

Closed
Maddiaa0 opened this issue Aug 30, 2023 · 0 comments
Closed
Labels
C-aztec.nr Component: Aztec smart contract framework

Comments

@Maddiaa0
Copy link
Member

Maddiaa0 commented Aug 30, 2023

Right now all open functions have a return value keyword at the beginning. This is then included in the abi and included in the contract's function tree. And also determines that brillig should be generated for the function. The use of the open keyword was chosen as public is considered overloaded. Consensus has such changed; the public keyword is now deemed suitable for this.

#[aztec(public)]
open fn some_function() {
    // ...
}

Should become:

#[aztec(public)]
fn some_function() {
    // ...
}

But maintain the same functionality

Tracked by #1891

@iAmMichaelConnor iAmMichaelConnor added this to the 📢 Initial Public Sandbox Release milestone Aug 30, 2023
@iAmMichaelConnor iAmMichaelConnor added the C-aztec.nr Component: Aztec smart contract framework label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-aztec.nr Component: Aztec smart contract framework
Projects
Archived in project
Development

No branches or pull requests

2 participants