Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--platform-version option for oryx build command is from the App Setting FUNCTION_EXTENSION_VERSION #238

Open
horihiro opened this issue Dec 4, 2021 · 0 comments

Comments

@horihiro
Copy link

horihiro commented Dec 4, 2021

When setting FUNCTION_WORKER_RUNTIME to dotnet and ENABLE_ORYX_BUILD to true, the option --platform-version of the oryx build command seems to be from an App Setting FUNCTION_EXTENSION_VERSION.

For example, if setting FUNCTION_EXTENSION_VERSION to ~4,
image
the command option is set to --platform-version ~4 as the following screenshot.
image

It means when building by using .NET5/6 SDK, the App Setting FUNCTION_WORKER_RUNTIME should be set to ~5/~6.
Of course, these values are invalid for the function host, then the host is down by the setting.

Could you please check if this is expected behavior?

The codes for selecting the version are these lines.

var workerVersion = ResolveWorkerRuntimeVersion(FunctionsWorkerRuntime);
if (!string.IsNullOrEmpty(workerVersion))
{
Version = workerVersion;
OryxArgumentsHelper.AddLanguageVersion(args, workerVersion);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant