Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] AppCreationScripts and ReadMe need updating #158

Open
SergeyDubinets opened this issue Jan 19, 2021 · 0 comments
Open

[Bug] AppCreationScripts and ReadMe need updating #158

SergeyDubinets opened this issue Jan 19, 2021 · 0 comments
Labels

Comments

@SergeyDubinets
Copy link

SergeyDubinets commented Jan 19, 2021

https://github.com/Azure-Samples/active-directory-xamarin-native-v2/tree/master/1-Basic

I see two distinct issues:

  1. Configure1.ps is broken. It searches for clientID: "7d8cef0-4145-49b2-a91d-95c54051fa3f" wile source files use now "4a1aa1d5-c567-49d0-ad0b-cd957a47f842" as a result script doesn't do its work.

  2. Change ba736f2 [Author: Jean-Marc Prieur [email protected] 2020-06-02 04:57:07]
    Added the use of WebAuthenticationBroker.GetCurrentApplicationCallbackUri().
    Now sample works with your clientID but when I substitute another clientID on UWP I get an error that callback URI is unrecognized.
    There is no surprise in this as on UWP we pass some different callback and APP registration doesn't know about it.
    Readme.md doesn't mention this and still shows old code https://github.com/Azure-Samples/active-directory-xamarin-native-v2/blob/master/1-Basic/README.md#about-the-code

@jmprieur jmprieur added the bug label Jan 19, 2021
@jennyf19 jennyf19 changed the title Sample 1-Basic is mostly broken. [Bug] AppCreationScripts and ReadMe need updating Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants