diff --git a/Project/src/MakeCall/CallCard.js b/Project/src/MakeCall/CallCard.js index 854f50a..c6fd1a9 100644 --- a/Project/src/MakeCall/CallCard.js +++ b/Project/src/MakeCall/CallCard.js @@ -75,6 +75,7 @@ export default class CallCard extends React.Component { selectedCameraDeviceId: props.selectedCameraDeviceId, selectedSpeakerDeviceId: this.deviceManager.selectedSpeaker?.id, selectedMicrophoneDeviceId: this.deviceManager.selectedMicrophone?.id, + isShowParticipants: false, showSettings: false, // StartWithNormal or StartWithDummy localScreenSharingMode: undefined, @@ -1115,39 +1116,86 @@ export default class CallCard extends React.Component { } -
- { - (this.state.callState === 'Connected' || - this.state.callState === 'LocalHold' || - this.state.callState === 'RemoteHold') && - this.state.allRemoteParticipantStreams.map(v => - - ) - } +
+
+

this.setState({isShowParticipants: !this.state.isShowParticipants})}>≡ Participants

+
+
+
{ - ( - this.state.remoteScreenShareStream && - - ) + this.state.callState === 'Connected' && this.state.isShowParticipants && +
+
+ { this.state.showAddParticipantPanel && + + } +
+
+ +
+ { + this.state.dominantSpeakerMode && +
+ Current dominant speaker: {this.state.dominantRemoteParticipant ? utils.getIdentifierText(this.state.dominantRemoteParticipant.identifier) : `None`} +
+ } + { + this.state.remoteParticipants.length === 0 && +

No other participants currently in the call

+ } +
    + { + this.state.remoteParticipants.map(remoteParticipant => + this.remoteParticipantSelectionChanged(identifier, isChecked)} + /> + ) + } +
+ +
} + +
+
+ { + (this.state.callState === 'Connected' || + this.state.callState === 'LocalHold' || + this.state.callState === 'RemoteHold') && + this.state.allRemoteParticipantStreams.map(v => + + ) + } + { + ( + this.state.remoteScreenShareStream && + + ) + } +
+
@@ -1650,46 +1698,6 @@ export default class CallCard extends React.Component {
} - { - this.state.callState === 'Connected' && -
-
-

Participants

-
-
- { this.state.showAddParticipantPanel && - - } -
-
- -
- { - this.state.dominantSpeakerMode && -
- Current dominant speaker: {this.state.dominantRemoteParticipant ? utils.getIdentifierText(this.state.dominantRemoteParticipant.identifier) : `None`} -
- } - { - this.state.remoteParticipants.length === 0 && -

No other participants currently in the call

- } -
    - { - this.state.remoteParticipants.map(remoteParticipant => - this.remoteParticipantSelectionChanged(identifier, isChecked)} - /> - ) - } -
-
- - }
); } diff --git a/Project/src/MakeCall/MakeCall.js b/Project/src/MakeCall/MakeCall.js index ec2505e..67776f6 100644 --- a/Project/src/MakeCall/MakeCall.js +++ b/Project/src/MakeCall/MakeCall.js @@ -162,21 +162,41 @@ export default class MakeCall extends React.Component { this.setState({ call: call }); const diagnosticChangedListener = (diagnosticInfo) => { - const rmsg = `UFD Diagnostic changed: - Diagnostic: ${diagnosticInfo.diagnostic} - Value: ${diagnosticInfo.value} - Value type: ${diagnosticInfo.valueType}`; - if (this.state.ufdMessages.length > 0) { - this.setState({ ufdMessages: [...this.state.ufdMessages, rmsg] }); - } else { - this.setState({ ufdMessages: [rmsg] }); - } - + const rmsg = `UFD Diagnostic changed: + Diagnostic: ${diagnosticInfo.diagnostic} + Value: ${diagnosticInfo.value} + Value type: ${diagnosticInfo.valueType}`; + if (this.state.ufdMessages.length > 0) { + // limit speakingWhileMicrophoneIsMuted diagnostic until another diagnostic is received + if (diagnosticInfo.diagnostic === 'speakingWhileMicrophoneIsMuted' && this.state.ufdMessages[0].includes('speakingWhileMicrophoneIsMuted')) { + console.info(rmsg); + return; + } + this.setState({ ufdMessages: [rmsg, ...this.state.ufdMessages] }); + } else { + this.setState({ ufdMessages: [rmsg] }); + } + }; + const remoteDiagnosticChangedListener = (diagnosticArgs) => { + diagnosticArgs.diagnostics.forEach(diagnosticInfo => { + const rmsg = `UFD Diagnostic changed: + Diagnostic: ${diagnosticInfo.diagnostic} + Value: ${diagnosticInfo.value} + Value type: ${diagnosticInfo.valueType} + Participant Id: ${diagnosticInfo.participantId} + Participant name: ${diagnosticInfo.remoteParticipant?.displayName}`; + if (this.state.ufdMessages.length > 0) { + this.setState({ ufdMessages: [rmsg, ...this.state.ufdMessages] }); + } else { + this.setState({ ufdMessages: [rmsg] }); + } + }); }; call.feature(Features.UserFacingDiagnostics).media.on('diagnosticChanged', diagnosticChangedListener); call.feature(Features.UserFacingDiagnostics).network.on('diagnosticChanged', diagnosticChangedListener); + call.feature(Features.UserFacingDiagnostics).remote?.on('diagnosticChanged', remoteDiagnosticChangedListener); }); e.removed.forEach(call => { diff --git a/Project/src/MakeCall/RemoteParticipantCard.js b/Project/src/MakeCall/RemoteParticipantCard.js index bd37a5f..a31b723 100644 --- a/Project/src/MakeCall/RemoteParticipantCard.js +++ b/Project/src/MakeCall/RemoteParticipantCard.js @@ -110,6 +110,10 @@ export default class RemoteParticipantCard extends React.Component { return menuItems.filter(item => item != 0) } + getSecondaryText() { + return `${this.state.state} | ${this.state.participantIds.toString()}`; + } + async handleRemoteRaiseHand() { try { if (this.state.isHandRaised) { @@ -157,7 +161,7 @@ export default class RemoteParticipantCard extends React.Component { this.state.displayName : this.state.participantIds.toString() } - secondaryText={this.state.state} + secondaryText={this.getSecondaryText()} styles={{ primaryText: {color: '#edebe9'}, secondaryText: {color: '#edebe9'} }}/>