Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This sample should be using the Microsoft Graph SDK to demonstrate best practices #19

Open
baywet opened this issue Mar 8, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@baywet
Copy link
Member

baywet commented Mar 8, 2021

Hi,
Thanks for putting the sample together, OBO is a common request when people are trying to interact with Microsoft Graph.

I believe that this sample should be using (and demonstrating) the use of the SDK instead of crafting requests manually. This way customers would see the full, end to end scenario, and not just auth.

String result = restTemplate.exchange("https://graph.microsoft.com/v1.0/me", HttpMethod.GET,

@idg-sam
Copy link
Contributor

idg-sam commented Mar 16, 2021

Hi Vincent,
I agree with you fully. We are utilizing Graph SDK in our new chapter-wise samples, and so far, two of our new chapters implement Graph SDK features.

Please see Chapter 2.1 (call graph) in the chapter-wise MSAL Java tutorial where we demonstrate a web app getting /me data using Graph SDK. We also make use of Graph SDK in the Chapter 3.2 (Groups), where we receive group memberships using Graph SDK if there are too many to fit in an ID token.

Once I get a chance to work on the new OBO chapter in the upcoming weeks, we'll use Graph SDK to make the requests. I think this sample with manual Graph calls will be archived at that point.

@idg-sam idg-sam added the enhancement New feature or request label Mar 16, 2021
@baywet
Copy link
Member Author

baywet commented Mar 16, 2021

thanks for the insights! let's keep this issue open to track the progress for now.

@Avery-Dunn Avery-Dunn self-assigned this Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants