Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Flags are loaded randomly in the ConfigMap #75

Open
simonmalletrc opened this issue Oct 24, 2024 · 3 comments
Open

Feature Flags are loaded randomly in the ConfigMap #75

simonmalletrc opened this issue Oct 24, 2024 · 3 comments

Comments

@simonmalletrc
Copy link

simonmalletrc commented Oct 24, 2024

Hello,

We have just finished configuring AppConfiguration Kubernetes Provider in our infrastructure and everything seems to be working except for the feature flags.

When I use the spec.featureFlag.refresh in conjuction with stakater/reloader, every refresh it does a rolling update.

Rolling updates are done only when changes are detected.
After investigation we found out that the order in which feature flags are loaded in the ConfigMap are completely random instead of being in alphabetical order which triggers a rolling update every refresh.

        featureFlag: #Optional. it is the content spec.featureFlag in the doc https://learn.microsoft.com/en-ca/azure/azure-app-configuration/reference-kubernetes-provider?tabs=default.
          selectors:
          - keyFilter: "*"
          - keyFilter: "*"
            labelFilter: dev
          - keyFilter: "*"
            labelFilter: dev35
          refresh:
            enabled: true
            interval: 1m

Expected Result

Rolling update only when actual changes

Actual Result

Rolling update with same Feature Flag values (because of feature flags being loaded randomly in the ConfigMap)

@simonmalletrc simonmalletrc changed the title Refresh using sentinel key for feature Flag does not exist Feature Flags are loaded randomly in the ConfigMap Oct 24, 2024
@linglingye001
Copy link
Contributor

Hi @simonmalletrc , currently the Kubernetes provider pulls the latest feature flag settings from the app config store every refresh interval and regenerate the ConfigMap (even if the content hasn't changed). We already have PR aimed at optimizing this refresh process, so that the ConfigMap will only be updated when the selected keyValues/featureFlags really change. This enhancement will be included in the next version, please stay tuned.

@simonmalletrc
Copy link
Author

Thank you !

@RichardChen820
Copy link
Contributor

It's been fixed in the latest v2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants