Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical vulnerability in tough-cookie #2457

Open
justinmchase opened this issue Aug 27, 2024 · 3 comments
Open

Critical vulnerability in tough-cookie #2457

justinmchase opened this issue Aug 27, 2024 · 3 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@justinmchase
Copy link

Which service(blob, file, queue, table) does this issue concern?

all

Which version of the Azurite was used?

latest

Where do you get Azurite? (npm, DockerHub, NuGet, Visual Studio Code Extension)

docker hub and npm

What's the Node.js version?

20

What problem was encountered?

CVE-2023-26136 found in [email protected]

Steps to reproduce the issue?

npm i
npm ls tough-cookie

Have you found a mitigation/solution?

Upgrade to latest version of @azure/ms-rest-js, which has removed tough-cookie.

npm i @azure/[email protected]
@blueww blueww added the dependencies Pull requests that update a dependency file label Aug 28, 2024
@blueww
Copy link
Member

blueww commented Aug 28, 2024

@EmmaZhu

Would you please help to look at the dependency issue?

@EmmaZhu
Copy link
Member

EmmaZhu commented Aug 29, 2024

Upgrading to the latest @azure/ms-rest-js may not be able to resolve the issue. Azurite still has dependency on [email protected] which may be indirectly introduced by some Azurite's dependencies. I'll work on this to find out which dependencies introduce to see how we can fix this vulnerability.

@justinmchase
Copy link
Author

I was able to workaround this by building a Docker image which includes this line:

RUN npm install azureite -g && \
    cd /usr/local/lib/node_modules/azurite && \
    npm upgrade && \
    npm i @azure/[email protected]

The result is an upgraded and functioning azurite that no longer has any security vulnerabilities.

Which leads me to believe that all you need to do to get this resolved in this repo is to run:

npm upgrade
npm i @azure/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants