Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override-client-name doesn't allow periods #4987

Open
2 tasks done
benwa opened this issue Jul 1, 2024 · 0 comments
Open
2 tasks done

override-client-name doesn't allow periods #4987

benwa opened this issue Jul 1, 2024 · 0 comments
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@benwa
Copy link

benwa commented Jul 1, 2024

Before filling a bug

  • have you checked the faq for known issues.
  • have you checked existing issues

Describe the bug
When building a PowerShell module, I see that override-client-name removes all periods, which are a valid character.

Expected behavior
Periods are not removed from the module name.

Additional context
See PagerDutyEventsV1, which should be PagerDuty.EventsV1. You can see that periods are allowed, as both Microsoft.PowerShell.Management and Microsoft.PowerShell.Utility include them.

S /home/ben [PagerDutyEventsV1]> Get-Module

ModuleType Version    PreRelease Name                                ExportedCommands
---------- -------    ---------- ----                                ----------------
Manifest   7.0.0.0               Microsoft.PowerShell.Management     {Add-Content, Clear-…
Manifest   7.0.0.0               Microsoft.PowerShell.Utility        {Add-Member, Add-Typ…
Script     0.1.0                 PagerDutyEventsV1                   New-EventV1
Script     2.3.5                 PSReadLine                          {Get-PSReadLineKeyHa

readme.md

    ```yaml
    powershell: true
    clear-output-folder: true
    license-header: MICROSOFT_MIT_NO_VERSION
    ```
    
    ```yaml $(tag) == 'events-v1'
    namespace: PagerDuty.EventsV1
    override-client-name: PagerDuty.EventsV1
    input-file: events-v1.json
    output-folder: events-v1
    directive:
    - select: command
      where:
        subject: (^V1)(.*)
      set:
        subject: $2V1
    - where:
        parameter-name: Client
      set:
        parameter-name: ClientName
    ```
@microsoft-github-policy-service microsoft-github-policy-service bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jul 1, 2024
@benwa benwa changed the title override-client-name doesn't allow for periods override-client-name doesn't allow periods Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

1 participant