Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.NetworkCloud AZ-CLI-EXTENSIONS updated with API version 202… #7893

Merged
merged 12 commits into from
Sep 5, 2024

Conversation

MikePham0630
Copy link
Member

@MikePham0630 MikePham0630 commented Aug 19, 2024

…4-06-01-preview


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Aug 19, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️networkcloud
rule cmd_name rule_message suggest_message
⚠️ 1009 - ParaPropRemove networkcloud cloudservicesnetwork update cmd networkcloud cloudservicesnetwork update update parameter enable_default_egress_endpoints: removed property aaz_default=True
⚠️ 1009 - ParaPropRemove networkcloud cloudservicesnetwork update cmd networkcloud cloudservicesnetwork update update parameter enable_default_egress_endpoints: removed property default=True
⚠️ 1001 - CmdAdd networkcloud cluster continue-update-version cmd networkcloud cluster continue-update-version added
⚠️ 1006 - ParaAdd networkcloud cluster create cmd networkcloud cluster create added parameter command_output_settings
⚠️ 1006 - ParaAdd networkcloud cluster create cmd networkcloud cluster create added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkcloud cluster create cmd networkcloud cluster create added parameter mi_user_assigned
⚠️ 1006 - ParaAdd networkcloud cluster update cmd networkcloud cluster update added parameter command_output_settings
⚠️ 1006 - ParaAdd networkcloud cluster update cmd networkcloud cluster update added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkcloud cluster update cmd networkcloud cluster update added parameter mi_user_assigned
⚠️ 1006 - ParaAdd networkcloud clustermanager create cmd networkcloud clustermanager create added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkcloud clustermanager create cmd networkcloud clustermanager create added parameter mi_user_assigned
⚠️ 1006 - ParaAdd networkcloud clustermanager update cmd networkcloud clustermanager update added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkcloud clustermanager update cmd networkcloud clustermanager update added parameter mi_user_assigned
⚠️ 1010 - ParaPropUpdate networkcloud kubernetescluster agentpool create cmd networkcloud kubernetescluster agentpool create update parameter kubernetes_cluster_name: updated property options from ['--kubernetes-cluster-name'] to ['--kc-name', '--kubernetes-cluster-name']
⚠️ 1010 - ParaPropUpdate networkcloud kubernetescluster agentpool delete cmd networkcloud kubernetescluster agentpool delete update parameter kubernetes_cluster_name: updated property options from ['--kubernetes-cluster-name'] to ['--kc-name', '--kubernetes-cluster-name']
⚠️ 1010 - ParaPropUpdate networkcloud kubernetescluster agentpool list cmd networkcloud kubernetescluster agentpool list update parameter kubernetes_cluster_name: updated property options from ['--kubernetes-cluster-name'] to ['--kc-name', '--kubernetes-cluster-name']
⚠️ 1010 - ParaPropUpdate networkcloud kubernetescluster agentpool show cmd networkcloud kubernetescluster agentpool show update parameter kubernetes_cluster_name: updated property options from ['--kubernetes-cluster-name'] to ['--kc-name', '--kubernetes-cluster-name']
⚠️ 1010 - ParaPropUpdate networkcloud kubernetescluster agentpool update cmd networkcloud kubernetescluster agentpool update update parameter kubernetes_cluster_name: updated property options from ['--kubernetes-cluster-name'] to ['--kc-name', '--kubernetes-cluster-name']
⚠️ 1010 - ParaPropUpdate networkcloud kubernetescluster agentpool wait cmd networkcloud kubernetescluster agentpool wait update parameter kubernetes_cluster_name: updated property options from ['--kubernetes-cluster-name'] to ['--kc-name', '--kubernetes-cluster-name']
⚠️ 1011 - SubgroupAdd networkcloud kubernetescluster feature sub group networkcloud kubernetescluster feature added
⚠️ 1010 - ParaPropUpdate networkcloud virtualmachine create cmd networkcloud virtualmachine create update parameter memory_size_gb: updated property name from memory_size_gb to memory_size_gib
⚠️ 1010 - ParaPropUpdate networkcloud virtualmachine create cmd networkcloud virtualmachine create update parameter memory_size_gb: updated property options from ['--memory-size', '--memory-size-gb'] to ['--memory-size', '--memory-size-gb', '--memory-size-gib']

Copy link

Hi @MikePham0630,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 19, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Aug 19, 2024

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 19, 2024
@MikePham0630
Copy link
Member Author

Corresponding aaz updates: Azure/aaz#545

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 19, 2024
@kairu-ms kairu-ms assigned necusjz and unassigned kairu-ms Aug 26, 2024
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 29, 2024
@AllyW
Copy link
Member

AllyW commented Aug 30, 2024

@MikePham0630 according to extension versioning rule below:

the major version number of preview can increase by at most one compared to the last stable version. For example, the last stable version is 2.0.0, if there are breaking changes for next preview release, the version will be 3.0.0b1. Then another breaking changes for the next preview release, the version will be 3.0.0b2

https://github.com/Azure/azure-cli/blob/release/doc/extensions/versioning_guidelines.md#notes-1

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 30, 2024
@necusjz necusjz merged commit 3b53055 into Azure:main Sep 5, 2024
20 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Sep 5, 2024

[Release] Update index.json for extension [ networkcloud ] : https://dev.azure.com/azclitools/release/_build/results?buildId=187046&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants