Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{storagesync} Remove ADAL dependencies #7933

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

cxznmhdcxz
Copy link
Member

@cxznmhdcxz cxznmhdcxz commented Aug 30, 2024

Remove ADAL dependencies,
replace functions/models in msrestazure library with parity functions in azure.mgmt.core library or azure.core library


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Aug 30, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @cxznmhdcxz,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 30, 2024

storagesync

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

@cxznmhdcxz cxznmhdcxz marked this pull request as ready for review September 2, 2024 01:43
@jsntcy jsntcy merged commit 03d4aa3 into Azure:main Sep 3, 2024
20 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Sep 3, 2024

[Release] Update index.json for extension [ storagesync ] : https://dev.azure.com/azclitools/release/_build/results?buildId=186378&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Storagesync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants