Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove msrestazure dependency in Fleet extension #7941

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

jim-minter
Copy link
Member

Remove msrestazure dependency in Fleet extension


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Sep 2, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @jim-minter,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 2, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Sep 2, 2024

@jsntcy
Copy link
Member

jsntcy commented Sep 3, 2024

@jim-minter, did you run related tests using the command azdev test xxx locally?

@jim-minter
Copy link
Member Author

@jim-minter, did you run related tests using the command azdev test xxx locally?

@jsntcy, yes.

@jim-minter
Copy link
Member Author

Please merge.

@jsntcy jsntcy merged commit 6940b70 into Azure:main Sep 5, 2024
21 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Sep 5, 2024

[Release] Update index.json for extension [ fleet ] : https://dev.azure.com/azclitools/release/_build/results?buildId=187214&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants