Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{CI} Remove deprecated assertRaisesRegexp and assertEquals in test #8010

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

{CI} Remove deprecated assertRaisesRegexp and assertEquals in test #8010

wants to merge 2 commits into from

Conversation

bebound
Copy link
Contributor

@bebound bebound commented Sep 23, 2024

assertRaisesRegexp is removed in 3.12: Azure/azure-cli#29504
assertEquals is removed in 3.12: Azure/azure-cli#29515

@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 23, 2024 •
edited
Loading

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

Hi @bebound,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 23, 2024

CI

@github-actions GitHub Actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions GitHub Actions
Copy link

@bebound bebound mentioned this pull request Sep 23, 2024
Open
4 tasks
Pan-Qi
Pan-Qi approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Pan-Qi Pan-Qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed some ending line of file, other than that LGTM

src/apic-extension/azext_apic_extension/tests/latest/test_definition_commands.py
os.remove(self.kwargs['filename'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ending line

src/authV2/azext_authV2/tests/latest/test_authV2_scenario.py
self.assertIn('https://audience1', result['allowedAudiences'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ending line

src/azure-firewall/azext_firewall/tests/latest/test_azure_firewall_scenario.py
self.cmd('network firewall policy delete -g {rg} --name {policy_name_2}')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ending line

src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py
os.remove("%s" % (_get_test_data_file(managed_cluster_name + '-config.yaml')))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ending line

src/network-analytics/azext_network_analytics/tests/latest/test_network_analytics.py
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ending line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pan-Qi Pan-Qi Pan-Qi approved these changes

@zhoxing-ms zhoxing-ms Awaiting requested review from zhoxing-ms zhoxing-ms is a code owner

@jsntcy jsntcy Awaiting requested review from jsntcy jsntcy is a code owner

@jiasli jiasli Awaiting requested review from jiasli jiasli is a code owner

@necusjz necusjz Awaiting requested review from necusjz necusjz is a code owner

@kairu-ms kairu-ms Awaiting requested review from kairu-ms kairu-ms is a code owner

@wangzelin007 wangzelin007 Awaiting requested review from wangzelin007

@yonzhan yonzhan Awaiting requested review from yonzhan

Assignees

@wangzelin007 wangzelin007

Labels
Auto-Assign Auto assign by bot CI
Projects
None yet
Milestone
September 2024 (2024-10-08)
Development

Successfully merging this pull request may close these issues.
4 participants
@bebound @yonzhan @Pan-Qi @wangzelin007