{AKS} [KMS] Update tests to use vnet integration #8021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzhecheng
requested review from
andyliuliming and
FumingZhang
as code owners
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @lzhecheng, |
|
KMS |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
yonzhan
|
FumingZhang
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Queued live test to validate the change
- test_aks_create_with_azurekeyvaultkms_private_key_vault
- test_aks_update_with_azurekeyvaultkms_private_key_vault
- test_aks_create_with_azurekeyvaultkms_private_cluster_v1_private_key_vault
FumingZhang
reviewed
Sep 25, 2024
| "--assign-identity {identity_id} " | ||
| "--enable-azure-keyvault-kms --azure-keyvault-kms-key-id={key_id} " | ||
| "--azure-keyvault-kms-key-vault-network-access=Private --azure-keyvault-kms-key-vault-resource-id {kv_resource_id} " | ||
| "--enableVnetIntegration=true " |
There was a problem hiding this comment.
The option name should be --enable-apiserver-vnet-integration
lzhecheng
force-pushed
the
kms-test-use-vnet-integration
branch
from
b16c88b
to
389c934
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
private keyvault + konnectivity is blocked now, so vnet integration should be used. Signed-off-by: Zhecheng Li <[email protected]>
lzhecheng
force-pushed
the
kms-test-use-vnet-integration
branch
from
389c934
to
1c7a6ac
Compare
lzhecheng
changed the title
|
@zhoxing-ms @yanzhudd Could you please merge this one? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
private keyvault + konnectivity is blocked now, so vnet integration should be used.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create/update --enable-azure-keyvault-kms
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.