-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate db-up extension #8027
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Deprecate db-up extension |
|
@@ -32,20 +37,27 @@ def load_command_table(self, _): # pylint: disable=too-many-locals, too-many-st | |||
from ._exception_handler import password_handler | |||
g.custom_command('up', 'mysql_up', validator=db_up_namespace_processor('mysql'), | |||
table_transformer=table_transform_connection_string, | |||
exception_handler=password_handler) | |||
exception_handler=password_handler, | |||
deprecate_info=g.deprecate(message_func=_deprecation_message)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to set deprecate_info
at command group mysql
level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not appropriate because az mysql
is also defined in Mysql
module in cli main repo and it's not going to be deprecated. That's why I add the deprecation for each command
[Release] Update index.json for extension [ db-up ] : https://dev.azure.com/azclitools/release/_build/results?buildId=193406&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.