Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: redisenterprise microsoft.cache 2024 09 01 preview #8028

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

priyankarking
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Sep 26, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️redisenterprise
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd redisenterprise create cmd redisenterprise create added parameter access_keys_authentication
⚠️ 1006 - ParaAdd redisenterprise create cmd redisenterprise create added parameter high_availability

Copy link

Hi @priyankarking,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 26, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Sep 26, 2024

@evelyn-ys
Copy link
Member

Pls add tests for new features

Priyankar gupta added 2 commits September 26, 2024 15:17
…1-preview' of https://github.com/priyankarking/azure-cli-extensions into priyankarking-redisenterprise-Microsoft.cache-2024-09-01-preview
…1-preview' of https://github.com/priyankarking/azure-cli-extensions into priyankarking-redisenterprise-Microsoft.cache-2024-09-01-preview
@priyankarking priyankarking force-pushed the priyankarking-redisenterprise-Microsoft.cache-2024-09-01-preview branch from f1f4f0d to 10be9da Compare September 27, 2024 10:38
@priyankarking
Copy link
Contributor Author

Pls add tests for new features

added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants