[Internal] Client Telemetry: Adds condition to make sure metrics is always there #4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
kirankumarkolli,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
sourabh1007
force-pushed
the
users/sourabhjain/nullchecks
branch
from
8f76022
to
09cb866
Compare
sourabh1007
added
Telemetry
and removed
Do Not Review
sourabh1007
force-pushed
the
users/sourabhjain/nullchecks
branch
from
11ecfb9
to
2a6af07
Compare
|
Closing this as this is stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Client Telemetry Service do not accept partial metric information except
SystemPool_IsThreadStarving_Truemetrics because service knows this particular metrics doesn't have percentile calculated.As part of this PR, making sure metrics is added in payload only if there is metrics information available. It means if corresponding histogram has any value then only do any calculations otherwise just skip that metrics.