Wrong delimiter in Query Metrics

[psdutkiewicz]

Describe the bug
Calling CosmosAsyncContainer.queryItems() with FeedOptions.isPopulateQueryMetrics() == true produces java.lang.NumberFormatException

To Reproduce
Call CosmosAsyncContainer.queryItems() with FeedOptions.isPopulateQueryMetrics() == true

Expected behavior
Should parse metrics.

Actual behavior
java.lang.NumberFormatException is thrown

Environment summary
SDK Version: 4.0.1
Java JDK version: 11
OS Version: Win10

Additional context
Adding Locale.US into String.format() should fix this issue.

azure-cosmosdb-java/gateway/src/main/java/com/microsoft/azure/cosmosdb/rx/internal/query/DocumentProducer.java

Line 91 in 5fe53f7

queryMetricsDelimitedString += String.format(";%s=%.2f", QueryMetricsConstants.RequestCharge, pageResult.getRequestCharge());

[kushagraThapar]

@psdutkiewicz - this repository represents azure-cosmosdb version 2.x.x
v4 cosmos SDK is located here : https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/cosmos/azure-cosmos
which version of SDK are you using, since 4.0.1 is not released yet.

[psdutkiewicz]

@kushagraThapar Of course I made a mistake and made an issue in wrong repo... Sorry for that.

Nevertheless, here is the same issue. Of course, default Locale can be set by user to properly parse double to string, but I think this code should not depend on user Locale settings.

azure-cosmosdb-java/gateway/src/main/java/com/microsoft/azure/cosmosdb/rx/internal/query/DocumentProducer.java

Line 91 in 5fe53f7

queryMetricsDelimitedString += String.format(";%s=%.2f", QueryMetricsConstants.RequestCharge, pageResult.getRequestCharge());