The template parameters 'undefined' in the parameters file are not valid when using Create Azure DevTest Labs VM #773
Comments
sbugalski
changed the title
|
@sbugalski, thank you for the details. Let me take a look and try to repro. It would help if you can also share the parameters file you used. |
|
@sbugalski, I have tried to repro your case, but I cannot get it to fail. When you get a chance, please provide the parameters file so I can see if I can repro the case with it. Thanks. |
|
@leovms - it fails for me even after modifying template. Please see attached ARM templates and parameters (had to save as .txt) |
|
@sbugalski, can you try changing the type for the respective parameters from "disallowPublicIpAddress": {
"type": "string",
"defaultValue": false
},
"allowClaim": {
"type": "string",
"defaultValue": true
} |
|
@sbugalski, I'm going to try a different approach to try to repro your scenario. Do let me know if the above helps in any way. |
|
@sbugalski, I tried another approach to repro the One other thing you can try is to add a new instance of the task. Can you do that or just let me know if you did that already? |
|
@leovms - my template works with well known ARM Deployment scripts or tasks. I had exported an ARM template, so it's clean export, without any changes and still fails with undefined parameter issue. also it woks with ARM whatif. |
|
@leovms - my template works with well known ARM Deployment scripts or tasks. I had exported an ARM template, so it's clean export, without any changes and still fails with undefined parameter issue. ARM template attached. also it woks with |
|
Having the same issue, when using the Azure DevOps task, I cannot create a DevTest Lab VM as the task injects an undefined value:
|
|
Thank you for the reports. I'm actively looking at this. Can you tell me which agent you are using? Is it hosted, custom? If hosted, which one? I'm using a custom agent host with the latest agent version. |
|
I am using a hosted agent. Agent specifications : windows 2019 |
|
@YassinElf, thank you. I just ran a build that has a template and template parameter files against a hosted Windows 2019 agent and it worked for me. I can't repro it. Is it perhaps related to the encoding of the file? We assume UTF8. |
|
Can you please share me, if possible, your template and template parameters files so we can test it on our pipeline ? All we do is replace tokens on our template parameters files to get the release variables, then set some more env variable with a powershell task, then we are running the Create Azure DevTest Lab VM. Here is the yaml template for the task : Thank you |
|
When running our templates locally with a New-AzResourceGroupDeployment, it creates the DevTest Lab VM in the specified lab. |
|
@YassinElf, it is the same one provided in this thread. I just changed values to match my config. I think the missing link here is YAML. Let me try creating a YAML pipeline. I am not using YAML in my setup. Can you do the opposite and try creating a regular pipeline with the task? |
|
@YassinElf, I just validated with YAML pipeline and that also worked for me. Are we able to maybe connect offline? It may help identify what's different. |
|
@leovms - do you have any ideas why both me and @YassinElf have the issue, whereas you don't? |
|
@sbugalski, unfortunately, I do not. Someone else internally tried it as well and same result. I'm trying to understand the commonality to see if I can repro it. So far, I have tried the following:
Can you think of anything else that may be different? |
|
@sbugalski @YassinElf We had the same problem. The Azure DevTest Labs Create VM task worked well until April/May 2021, and then for the same files as before, we started receiving the errors:
That's a hint for you @leovms. One of the commits between the 9th of April and the 21st of May destroyed pipelines in all our projects. We've found a workaround. |
@DXC-TTomasz appriciate that workaround :D |
|
This has been around for some time. I am not able to repro it, but what I did instead is added a guard to ensure that such parameter is not allowed. It will be ignored and it will not be added to the list. When version |
|
@leovms I'm getting the same issue on version 3.0.17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I've just find out the ms-azuredevtestlabs.tasks.azure-dtl-task-createvm.AzureDevTestLabsCreateVM@3 stopped working, because of adding undefined parameter with same value.
{ "$schema": "https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json", "contentVersion": "1.0.0.0", "parameters": { "newVMName": { "type": "string" }, "labName": { "type": "string", "defaultValue": "devtest" }, "size": { "type": "string", "defaultValue": "Standard_DS2_v2" }, "userName": { "type": "string", "defaultValue": "[REDACTED]" }, "password": { "type": "securestring", "defaultValue": "[[VmPassword]]" }, "Azure_Pipelines_Deployment_Group_Agent_accountUrl": { "type": "string", "defaultValue": "[REDACTED]" }, "Azure_Pipelines_Deployment_Group_Agent_projectName": { "type": "string", "defaultValue": "[REDACTED]" }, "Azure_Pipelines_Deployment_Group_Agent_deploymentGroupName": { "type": "string", "defaultValue": "[REDACTED]" }, "Azure_Pipelines_Deployment_Group_Agent_PersonalAccessToken": { "type": "securestring", "defaultValue": "[[PAT]]" }, "Azure_Pipelines_Deployment_Group_Agent_deploymentAgentTags": { "type": "string", "defaultValue": "WEB, DB" }, "Azure_Pipelines_Deployment_Group_Agent_agentInstallPath": { "type": "string", "defaultValue": "" }, "Azure_Pipelines_Deployment_Group_Agent_agentName": { "type": "string", "defaultValue": "" }, "Azure_Pipelines_Deployment_Group_Agent_RunAsAutoLogon": { "type": "bool", "defaultValue": false }, "Azure_Pipelines_Deployment_Group_Agent_windowsLogonAccount": { "type": "string", "defaultValue": "NT AUTHORITY\\NetworkService" }, "Azure_Pipelines_Deployment_Group_Agent_windowsLogonPassword": { "type": "securestring" } }, "variables": { "labSubnetName": "[concat(variables('labVirtualNetworkName'), 'Subnet')]", "labVirtualNetworkId": "[resourceId('Microsoft.DevTestLab/labs/virtualnetworks', parameters('labName'), variables('labVirtualNetworkName'))]", "labVirtualNetworkName": "[concat('Dtl', parameters('labName'))]", "vmId": "[resourceId ('Microsoft.DevTestLab/labs/virtualmachines', parameters('labName'), parameters('newVMName'))]", "vmName": "[concat(parameters('labName'), '/', parameters('newVMName'))]" }, "resources": [ { "apiVersion": "2018-10-15-preview", "type": "Microsoft.DevTestLab/labs/virtualmachines", "name": "[variables('vmName')]", "location": "[resourceGroup().location]", "properties": { "labVirtualNetworkId": "[variables('labVirtualNetworkId')]", "notes": "s001ci", "customImageId": "[REDACTED]", "size": "[parameters('size')]", "userName": "[parameters('userName')]", "password": "[parameters('password')]", "isAuthenticationWithSshKey": false, "artifacts": [ { "artifactId": "[resourceId('Microsoft.DevTestLab/labs/artifactSources/artifacts', parameters('labName'), 'public repo', 'windows-wsl')]" }, { "artifactId": "[resourceId('Microsoft.DevTestLab/labs/artifactSources/artifacts', parameters('labName'), 'public repo', 'windows-deploymentgroup')]", "parameters": [ { "name": "accountUrl", "value": "[parameters('Azure_Pipelines_Deployment_Group_Agent_accountUrl')]" }, { "name": "projectName", "value": "[parameters('Azure_Pipelines_Deployment_Group_Agent_projectName')]" }, { "name": "deploymentGroupName", "value": "[parameters('Azure_Pipelines_Deployment_Group_Agent_deploymentGroupName')]" }, { "name": "PersonalAccessToken", "value": "[parameters('Azure_Pipelines_Deployment_Group_Agent_PersonalAccessToken')]" }, { "name": "deploymentAgentTags", "value": "[parameters('Azure_Pipelines_Deployment_Group_Agent_deploymentAgentTags')]" }, { "name": "agentInstallPath", "value": "[parameters('Azure_Pipelines_Deployment_Group_Agent_agentInstallPath')]" }, { "name": "agentName", "value": "[parameters('Azure_Pipelines_Deployment_Group_Agent_agentName')]" }, { "name": "RunAsAutoLogon", "value": "[parameters('Azure_Pipelines_Deployment_Group_Agent_RunAsAutoLogon')]" }, { "name": "windowsLogonAccount", "value": "[parameters('Azure_Pipelines_Deployment_Group_Agent_windowsLogonAccount')]" }, { "name": "windowsLogonPassword", "value": "[parameters('Azure_Pipelines_Deployment_Group_Agent_windowsLogonPassword')]" } ] } ], "labSubnetName": "[variables('labSubnetName')]", "disallowPublicIpAddress": false, "storageType": "Premium", "allowClaim": false } } ], "outputs": { "labVMId": { "type": "string", "value": "[variables('vmId')]" } } }The ARM Template from powershell works flawless
As you can see, the task adds undefined parameter.
The text was updated successfully, but these errors were encountered: