Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectionMode.DirectHttps mode doesn't enforce RequestOptions' AccessCondition #129

Open
dyzwang opened this issue Jan 26, 2019 · 1 comment
Open

ConnectionMode.DirectHttps mode doesn't enforce RequestOptions' AccessCondition #129

dyzwang opened this issue Jan 26, 2019 · 1 comment

Comments

@dyzwang
Copy link

dyzwang commented Jan 26, 2019

I'm using the latest SDK 2.1.1. It seems that if I set ConnectionPolicy's connection mode to be DirectHttps, RequestOptions' AccessCondition (type: IfMatch) will no longer be enforced. Request with non matching AccessCondition would succeed. My expectation is that such request would get a 412 with {"Errors":["One of the specified pre-condition is not met"]} just like the Gateway connection mode, but it doesn't behave like that. This is a nasty bug, please fix it.
@srinathnarayanan
Copy link
Contributor

Hi @dyzwang , Can you please add a repro here or raise a ticket with [email protected] ?
I checked the behavior locally, and it looks to be working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dyzwang @srinathnarayanan