From c7c3e91fb7ea90f62df521324637721aac169d39 Mon Sep 17 00:00:00 2001 From: Shawnli222 Date: Mon, 30 Oct 2023 10:15:52 -0700 Subject: [PATCH 1/9] new --- ...New-AzApplicationGatewayFirewallCustomRuleGroupByVariable.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Network/Network/help/New-AzApplicationGatewayFirewallCustomRuleGroupByVariable.md b/src/Network/Network/help/New-AzApplicationGatewayFirewallCustomRuleGroupByVariable.md index 3911e8e6ffa3..5a1de388cf5a 100644 --- a/src/Network/Network/help/New-AzApplicationGatewayFirewallCustomRuleGroupByVariable.md +++ b/src/Network/Network/help/New-AzApplicationGatewayFirewallCustomRuleGroupByVariable.md @@ -53,7 +53,7 @@ User Session clause variable. Type: System.String Parameter Sets: (All) Aliases: -Accepted values: ClientAddr, Geo, GeoLocation, None +Accepted values: ClientAddr, Geo, None Required: True Position: Named From b1055a2b6d336e95334932172b9181793898ca2c Mon Sep 17 00:00:00 2001 From: Shawnli222 Date: Mon, 30 Oct 2023 10:19:49 -0700 Subject: [PATCH 2/9] new --- src/Network/Network/ChangeLog.md | 1 + ...licationGatewayFirewallCustomRuleGroupByVariableCommand.cs | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Network/Network/ChangeLog.md b/src/Network/Network/ChangeLog.md index 8bfeb656133b..0a9ca7f16532 100644 --- a/src/Network/Network/ChangeLog.md +++ b/src/Network/Network/ChangeLog.md @@ -19,6 +19,7 @@ ---> ## Upcoming Release +* Updated breaking change for parameter `VariableName` in `NewAzureApplicationGatewayFirewallCustomRuleGroupByVariable` to remove "Geo" as a valid input. ## Version 6.2.0 * Added support for new Application Gateway SKU type, Basic SKU diff --git a/src/Network/Network/FirewallPolicy/FirewallCustomRule/GroupByUserSession/GroupByVariable/NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand.cs b/src/Network/Network/FirewallPolicy/FirewallCustomRule/GroupByUserSession/GroupByVariable/NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand.cs index 74d692fd6f46..b915ce94ae1b 100644 --- a/src/Network/Network/FirewallPolicy/FirewallCustomRule/GroupByUserSession/GroupByVariable/NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand.cs +++ b/src/Network/Network/FirewallPolicy/FirewallCustomRule/GroupByUserSession/GroupByVariable/NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand.cs @@ -13,7 +13,6 @@ // ---------------------------------------------------------------------------------- using Microsoft.Azure.Commands.Network.Models; -using Microsoft.WindowsAzure.Commands.Common.CustomAttributes; using System.Linq; using System.Management.Automation; @@ -22,12 +21,11 @@ namespace Microsoft.Azure.Commands.Network [Cmdlet("New", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ApplicationGatewayFirewallCustomRuleGroupByVariable"), OutputType(typeof(PSApplicationGatewayFirewallCustomRuleGroupByVariable))] public class NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand : NetworkBaseCmdlet { - [CmdletParameterBreakingChangeWithVersionAttribute("VariableName", "11.0.0", "7.0.0", ChangeDescription = "Geo would be invalid for parameter VariableName")] [Parameter( Mandatory = true, HelpMessage = "User Session clause variable.")] [ValidateNotNullOrEmpty] - [ValidateSet("ClientAddr", "Geo", "GeoLocation", "None", IgnoreCase = true)] + [ValidateSet("ClientAddr", "Geo", "None", IgnoreCase = true)] public string VariableName { get; set; } public override void ExecuteCmdlet() From 6dd8b5a2bdf3a0e32da1f6cc8b7f4ed00e0a3fad Mon Sep 17 00:00:00 2001 From: Yabo Hu Date: Wed, 1 Nov 2023 18:35:45 +0800 Subject: [PATCH 3/9] Update ChangeLog.md --- src/Network/Network/ChangeLog.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Network/Network/ChangeLog.md b/src/Network/Network/ChangeLog.md index 0a9ca7f16532..e0e4af248a5f 100644 --- a/src/Network/Network/ChangeLog.md +++ b/src/Network/Network/ChangeLog.md @@ -19,7 +19,7 @@ ---> ## Upcoming Release -* Updated breaking change for parameter `VariableName` in `NewAzureApplicationGatewayFirewallCustomRuleGroupByVariable` to remove "Geo" as a valid input. +* [Breaking Change] Removed `Geo` as a valid input for parameter `VariableName` in `NewAzureApplicationGatewayFirewallCustomRuleGroupByVariable`. ## Version 6.2.0 * Added support for new Application Gateway SKU type, Basic SKU From 68add27c3a913d292256a74e920f86133103930a Mon Sep 17 00:00:00 2001 From: Yabo Hu Date: Wed, 1 Nov 2023 18:40:22 +0800 Subject: [PATCH 4/9] Update BreakingChangeIssues.csv --- .../Exceptions/Az.Network/BreakingChangeIssues.csv | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv b/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv index f6cfe8c592a1..751756e8ca9f 100644 --- a/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv +++ b/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv @@ -1,3 +1,4 @@ "Module","ClassName","Target","Severity","ProblemId","Description","Remediation" "Az.Network","Microsoft.Azure.Commands.Network.UpdateAzureRmRouteServer","Update-AzRouteServer","0","2020","The cmdlet 'Update-AzRouteServer' no longer supports the type 'System.Management.Automation.SwitchParameter' for parameter 'AllowBranchToBranchTraffic'.","Change the type for parameter 'AllowBranchToBranchTraffic' back to 'System.Management.Automation.SwitchParameter'." -"Az.Network","Microsoft.Azure.Commands.Network.UpdateAzureRmRouteServer","Update-AzRouteServer","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Update-AzRouteServer' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Update-AzRouteServer'." \ No newline at end of file +"Az.Network","Microsoft.Azure.Commands.Network.UpdateAzureRmRouteServer","Update-AzRouteServer","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Update-AzRouteServer' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Update-AzRouteServer'." +"Az.Network","Microsoft.Azure.Commands.Network.NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand","New-AzApplicationGatewayFirewallCustomRuleGroupByVariable","0","2040","The validation set for parameter 'VariableName' for cmdlet 'New-AzApplicationGatewayFirewallCustomRuleGroupByVariable' no longer contains the value 'GeoLocation'.","Add 'GeoLocation' back to the validation set for 'VariableName'." From 3b3bda213254f01a7eb7f4fddbabcaf12f264918 Mon Sep 17 00:00:00 2001 From: Shawnli222 Date: Thu, 2 Nov 2023 00:24:20 -0700 Subject: [PATCH 5/9] mistake --- ...pplicationGatewayFirewallCustomRuleGroupByVariableCommand.cs | 2 +- ...New-AzApplicationGatewayFirewallCustomRuleGroupByVariable.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Network/Network/FirewallPolicy/FirewallCustomRule/GroupByUserSession/GroupByVariable/NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand.cs b/src/Network/Network/FirewallPolicy/FirewallCustomRule/GroupByUserSession/GroupByVariable/NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand.cs index b915ce94ae1b..38b1c140acd2 100644 --- a/src/Network/Network/FirewallPolicy/FirewallCustomRule/GroupByUserSession/GroupByVariable/NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand.cs +++ b/src/Network/Network/FirewallPolicy/FirewallCustomRule/GroupByUserSession/GroupByVariable/NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand.cs @@ -25,7 +25,7 @@ public class NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand Mandatory = true, HelpMessage = "User Session clause variable.")] [ValidateNotNullOrEmpty] - [ValidateSet("ClientAddr", "Geo", "None", IgnoreCase = true)] + [ValidateSet("ClientAddr", "GeoLocation", "None", IgnoreCase = true)] public string VariableName { get; set; } public override void ExecuteCmdlet() diff --git a/src/Network/Network/help/New-AzApplicationGatewayFirewallCustomRuleGroupByVariable.md b/src/Network/Network/help/New-AzApplicationGatewayFirewallCustomRuleGroupByVariable.md index 5a1de388cf5a..a9fd75a13222 100644 --- a/src/Network/Network/help/New-AzApplicationGatewayFirewallCustomRuleGroupByVariable.md +++ b/src/Network/Network/help/New-AzApplicationGatewayFirewallCustomRuleGroupByVariable.md @@ -53,7 +53,7 @@ User Session clause variable. Type: System.String Parameter Sets: (All) Aliases: -Accepted values: ClientAddr, Geo, None +Accepted values: ClientAddr, GeoLocation, None Required: True Position: Named From 3652cc94277ea03780da78cd1da294a6d8c59661 Mon Sep 17 00:00:00 2001 From: Yabo Hu Date: Sun, 5 Nov 2023 18:47:23 +0800 Subject: [PATCH 6/9] Update BreakingChangeIssues.csv --- .../Exceptions/Az.Network/BreakingChangeIssues.csv | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv b/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv index 751756e8ca9f..2a872d03b3ef 100644 --- a/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv +++ b/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv @@ -1,4 +1,3 @@ "Module","ClassName","Target","Severity","ProblemId","Description","Remediation" "Az.Network","Microsoft.Azure.Commands.Network.UpdateAzureRmRouteServer","Update-AzRouteServer","0","2020","The cmdlet 'Update-AzRouteServer' no longer supports the type 'System.Management.Automation.SwitchParameter' for parameter 'AllowBranchToBranchTraffic'.","Change the type for parameter 'AllowBranchToBranchTraffic' back to 'System.Management.Automation.SwitchParameter'." "Az.Network","Microsoft.Azure.Commands.Network.UpdateAzureRmRouteServer","Update-AzRouteServer","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Update-AzRouteServer' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Update-AzRouteServer'." -"Az.Network","Microsoft.Azure.Commands.Network.NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand","New-AzApplicationGatewayFirewallCustomRuleGroupByVariable","0","2040","The validation set for parameter 'VariableName' for cmdlet 'New-AzApplicationGatewayFirewallCustomRuleGroupByVariable' no longer contains the value 'GeoLocation'.","Add 'GeoLocation' back to the validation set for 'VariableName'." From 45fa7fb4cc340533a7e915dfe3cbd89ff0beb377 Mon Sep 17 00:00:00 2001 From: Yabo Hu Date: Sun, 5 Nov 2023 18:51:27 +0800 Subject: [PATCH 7/9] Update ChangeLog.md --- src/Network/Network/ChangeLog.md | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/Network/Network/ChangeLog.md b/src/Network/Network/ChangeLog.md index fd8e6b7cac76..c297893a1119 100644 --- a/src/Network/Network/ChangeLog.md +++ b/src/Network/Network/ChangeLog.md @@ -21,16 +21,6 @@ ## Upcoming Release * [Breaking Change] Removed `Geo` as a valid input for parameter `VariableName` in `NewAzureApplicationGatewayFirewallCustomRuleGroupByVariable`. -## Version 6.2.0 -* Added support for new Application Gateway SKU type, Basic SKU -* Onboarded `Microsoft.EventGrid/partnerNamespaces` to private link cmdlets -* Onboarded `Microsoft.EventGrid/namespaces` to private link cmdlets -* Added AllowBranchToBranchTraffic property to New-AzRouteServer -* Added AllowBranchToBranchTraffic property to Get-AzRouteServer -* Changed Update-AzRouteServer functionality to fix bugs - - AllowBranchToBranchTraffic is now a bool - - Updating HubRoutingPreference property will not effect AllowBranchToBranchTraffic - ## Version 6.2.0 * Added support for new Application Gateway SKU type, Basic SKU * Onboarded `Microsoft.EventGrid/partnerNamespaces` to private link cmdlets From 1a57196c01dd30dfcdf368d200cfa39e1183812b Mon Sep 17 00:00:00 2001 From: Yabo Hu Date: Sun, 5 Nov 2023 18:52:46 +0800 Subject: [PATCH 8/9] Update ChangeLog.md --- src/Network/Network/ChangeLog.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/Network/Network/ChangeLog.md b/src/Network/Network/ChangeLog.md index c297893a1119..4158aac0e919 100644 --- a/src/Network/Network/ChangeLog.md +++ b/src/Network/Network/ChangeLog.md @@ -20,6 +20,11 @@ ## Upcoming Release * [Breaking Change] Removed `Geo` as a valid input for parameter `VariableName` in `NewAzureApplicationGatewayFirewallCustomRuleGroupByVariable`. +* Added AllowBranchToBranchTraffic property to New-AzRouteServer +* Added AllowBranchToBranchTraffic property to Get-AzRouteServer +* Changed Update-AzRouteServer functionality to fix bugs + - AllowBranchToBranchTraffic is now a bool + - Updating HubRoutingPreference property will not effect AllowBranchToBranchTraffic ## Version 6.2.0 * Added support for new Application Gateway SKU type, Basic SKU From 0f177f14807388d44022de4613bef8dc2be4f591 Mon Sep 17 00:00:00 2001 From: Yabo Hu Date: Mon, 6 Nov 2023 09:51:42 +0800 Subject: [PATCH 9/9] Update BreakingChangeIssues.csv --- .../Exceptions/Az.Network/BreakingChangeIssues.csv | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv b/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv index 2a872d03b3ef..4c0a1a880e09 100644 --- a/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv +++ b/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv @@ -1,3 +1,4 @@ "Module","ClassName","Target","Severity","ProblemId","Description","Remediation" "Az.Network","Microsoft.Azure.Commands.Network.UpdateAzureRmRouteServer","Update-AzRouteServer","0","2020","The cmdlet 'Update-AzRouteServer' no longer supports the type 'System.Management.Automation.SwitchParameter' for parameter 'AllowBranchToBranchTraffic'.","Change the type for parameter 'AllowBranchToBranchTraffic' back to 'System.Management.Automation.SwitchParameter'." "Az.Network","Microsoft.Azure.Commands.Network.UpdateAzureRmRouteServer","Update-AzRouteServer","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Update-AzRouteServer' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Update-AzRouteServer'." +"Az.Network","Microsoft.Azure.Commands.Network.NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand","New-AzApplicationGatewayFirewallCustomRuleGroupByVariable","0","2040","The validation set for parameter 'VariableName' for cmdlet 'New-AzApplicationGatewayFirewallCustomRuleGroupByVariable' no longer contains the value 'Geo'.","Add 'Geo' back to the validation set for 'VariableName'."