[Hub Generated] Review request for Microsoft.DesktopVirtualization to add version preview/2021-08-04-preview #15590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…table/2021-07-12 to version 2021-08-04-preview
- Change Date-Time format to an object specifying the hour and minute
- Update naming length requirements to match those in the greater Azure virtual desktop
- Adjust time zone to match ID in examples
|
Hi, @dallinlmag Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Must not have duplicate name of x-ms-enum extension , make sure every x-ms-enum name unique. The duplicate x-ms-enum name: hostpooltype, path: $.HostPoolProperties.properties.hostPoolType Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L4392 |
The following errors/warnings exist before current PR submission:
Only 25 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response of operation:'Workspaces_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L57 |
|
The response of operation:'ScalingPlans_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L324 |
|
The response of operation:'ApplicationGroups_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L591 |
|
The response of operation:'Applications_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L917 |
|
The response of operation:'Desktops_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L1160 |
|
The response of operation:'HostPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L1299 |
|
The response of operation:'SessionHosts_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L1667 |
|
The response of operation:'MSIXPackages_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L1859 |
|
The response of operation:'UserSessions_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L2156 |
|
The response of operation:'Workspaces_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L97 |
|
The response of operation:'ScalingPlans_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L364 |
|
The response of operation:'ApplicationGroups_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L631 |
|
The response of operation:'Applications_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L960 |
|
The response of operation:'HostPools_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L1339 |
|
The response of operation:'MSIXPackages_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L1902 |
|
The response of operation:'Workspaces_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L192 |
|
The response of operation:'ScalingPlans_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L459 |
|
The response of operation:'ApplicationGroups_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L726 |
|
The response of operation:'Applications_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L1061 |
|
The response of operation:'Desktops_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L1203 |
|
The response of operation:'HostPools_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L1441 |
|
The response of operation:'SessionHosts_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L1760 |
|
The response of operation:'MSIXPackages_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L2003 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L46 |
|
The integer type does not have a format, please add it. Location: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L2885 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 20 Errors, 85 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.0)
- current:preview/2021-08-04-preview/desktopvirtualization.json compared with base:stable/2021-07-12/desktopvirtualization.json
- current:preview/2021-08-04-preview/desktopvirtualization.json compared with base:preview/2021-05-13-preview/desktopvirtualization.json
The following breaking changes are detected by comparison with latest preview version:
Only 25 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/sessionHostConfigurations/default' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L1578:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/sessionHostConfigurations' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L1767:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/update' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L1812:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/controlUpdate' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L1864:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/updateDetails' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L1912:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/updateDetails/default' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L1957:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/updateValidationOperationResults/default' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L1999:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/updateOperationResults/default' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L2048:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/privateEndpointConnections' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L2973:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3019:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/privateLinkResources' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3162:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/workspaces/{workspaceName}/privateEndpointConnections' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3208:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/workspaces/{workspaceName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3254:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/workspaces/{workspaceName}/privateLinkResources' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3397:5 |
|
| The new version is missing a definition that was found in the old version. Was 'SessionHostConfiguration' removed or renamed? New: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L2449:3 Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3 |
|
| The new version is missing a definition that was found in the old version. Was 'SessionHostConfigurationProperties' removed or renamed? New: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L2449:3 Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ImageInfoProperties' removed or renamed? New: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L2449:3 Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3 |
|
| The new version is missing a definition that was found in the old version. Was 'MarketPlaceInfoProperties' removed or renamed? New: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L2449:3 Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3 |
|
| The new version is missing a definition that was found in the old version. Was 'DomainInfoProperties' removed or renamed? New: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L2449:3 Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3 |
|
| The new version is missing a definition that was found in the old version. Was 'CredentialsProperties' removed or renamed? New: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L2449:3 Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3 |
|
| The new version is missing a definition that was found in the old version. Was 'KeyVaultCredentialProperties' removed or renamed? New: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L2449:3 Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3 |
|
| The new version is missing a definition that was found in the old version. Was 'HostPoolUpdate' removed or renamed? New: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L2449:3 Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3 |
|
| The new version is missing a definition that was found in the old version. Was 'HostPoolUpdateConfigurationProperties' removed or renamed? New: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L2449:3 Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ScheduledTimeProperties' removed or renamed? New: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L2449:3 Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3 |
|
| The new version is missing a definition that was found in the old version. Was 'HostPoolControlParameter' removed or renamed? New: Microsoft.DesktopVirtualization/preview/2021-08-04-preview/desktopvirtualization.json#L2449:3 Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"desktopvirtualization/resource-manager/readme.md",
"tag":"package-preview-2021-08",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"desktopvirtualization/resource-manager/readme.md",
"tag":"package-preview-2021-08",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"desktopvirtualization/resource-manager/readme.md",
"tag":"package-preview-2021-08",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
This was referenced Aug 10, 2021
25 tasks
Updated examples to reflect the change and be more readable for customers.
|
Hi @dallinlmag, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit (including refactoring) and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.