[Hub Generated] Review request for Microsoft.SecurityInsights to add version stable/2021-04-01 #15692

laithhisham · 2021-08-18T15:07:02Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-08-18T15:07:04Z

Hi, @laithhisham Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-08-18T15:07:04Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.0)
- current:Microsoft.SecurityInsights/stable/2021-04-01 compared with base:Microsoft.SecurityInsights/stable/2021-04-01

Rule	Message
`❌` Runtime Exception	"new":"https://github.com/Azure/azure-rest-api-specs/blob/2f1edceb597b0a63d9d2ba988d022e9fd965353a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/stable/2021-04-01", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/stable/2021-04-01", "details":"Command failed: node /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/autorest/dist/app.js /tmp/readme.oad.old.md --tag=oad-default-tag --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions\n - file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/stable/2021-04-01/ThreatIntelligence.json:497:4 ($.definitions.CloudError)\n - file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/stable/2021-04-01/operations.json:70:4 ($.definitions.CloudError)\n - file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/stable/2021-04-01/Incidents.json:1039:4 ($.definitions.CloudErr"

️❌LintDiff: 2 Errors, 1 Warnings failed [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- securityinsights/resource-manager/readme.md tag:package-2021-04-01-only
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- securityinsights/resource-manager/readme.md tag:package-2021-04-01-only

The following errors/warnings are introduced by current PR:

Rule	Message
`❌` AutoRest exception	"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2021-04-01-only", "details":"swagger-document/compose - FAILED"
`❌` AutoRest exception	"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2021-04-01-only", "details":"Error: '$.definitions.AttackTactic.enum' has incompatible values (---- InitialAccess- Execution- Persistence- PrivilegeEscalation- DefenseEvasion- CredentialAccess- Discovery- LateralMovement- Collection"
⚠️ R1003 - ListInOperationName	Since operation 'ThreatIntelligenceIndicator_QueryIndicators' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.SecurityInsights/stable/2021-04-01/ThreatIntelligence.json#L311

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` AutoRest exception	"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2021-04-01-only", "details":"Duplicated model name with non-identical definitions"

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 1 Warnings warning [Detail]

The following tags are being changed in this PR

securityinsights/resource-manager/readme.md#package-2021-04-01-only

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ Modeler/MissingType	"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2021-04-01-only", "details":"The schema 'components·1qaufw0·schemas·threatintelligenceindicatorproperties·properties·extensions·additionalproperties' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/stable/2021-04-01/ThreatIntelligence.json#/components/schemas/components·1qaufw0·schemas·threatintelligenceindicatorproperties·properties·extensions·additionalproperties"
💬 AutorestCore/Exception	"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2021-04-01-only", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
💬 AutorestCore/Exception	"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2021-04-01-only", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"securityinsights/resource-manager/readme.md",
"tag":"package-2021-04-01-only",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-08-18T15:07:05Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌[Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-python-track2 - track2_azure-mgmt-securityinsight - 1.0.0b1

❌azure-sdk-for-go - securityinsight/mgmt/v1.0/securityinsight - v56.2.0

+	Package was removed

️✔️azure-sdk-for-go - securityinsight/mgmt/2020-01-01/securityinsight - v56.2.0
❌azure-sdk-for-go - preview/securityinsight/mgmt/2019-01-01-preview/securityinsight - v56.2.0

+	Const `KindAggregations` has been removed
+	Const `KindBasicEntityKindAccount` has been removed
+	Const `KindBasicEntityKindAzureResource` has been removed
+	Const `KindBasicEntityKindBookmark` has been removed
+	Const `KindBasicEntityKindCloudApplication` has been removed
+	Const `KindBasicEntityKindDNSResolution` has been removed
+	Const `KindBasicEntityKindEntity` has been removed
+	Const `KindBasicEntityKindFileHash` has been removed
+	Const `KindBasicEntityKindFile` has been removed
+	Const `KindBasicEntityKindHost` has been removed
+	Const `KindBasicEntityKindIP` has been removed
+	Const `KindBasicEntityKindIoTDevice` has been removed
+	Const `KindBasicEntityKindMailCluster` has been removed
+	Const `KindBasicEntityKindMailMessage` has been removed
+	Const `KindBasicEntityKindMailbox` has been removed
+	Const `KindBasicEntityKindMalware` has been removed
+	Const `KindBasicEntityKindProcess` has been removed
+	Const `KindBasicEntityKindRegistryKey` has been removed
+	Const `KindBasicEntityKindRegistryValue` has been removed
+	Const `KindBasicEntityKindSecurityAlert` has been removed
+	Const `KindBasicEntityKindSecurityGroup` has been removed
+	Const `KindBasicEntityKindSubmissionMail` has been removed
+	Const `KindBasicEntityKindURL` has been removed
+	Const `KindCasesAggregation` has been removed
+	Function `PossibleKindBasicEntityValues` has been removed
+	Function `ThreatIntelligenceIndicatorsClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string, string, string, *int32, string, string)` to `(context.Context, string, string, string, string, string, *int32, string)`
+	Function `ThreatIntelligenceIndicatorsClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string, string, string, *int32, string, string)` to `(context.Context, string, string, string, string, string, *int32, string)`
+	Function `ThreatIntelligenceIndicatorsClient.List` parameter(s) have been changed from `(context.Context, string, string, string, string, *int32, string, string)` to `(context.Context, string, string, string, string, string, *int32, string)`
+	Type of `AccountEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `Aggregations.Kind` has been changed from `Kind` to `KindBasicAggregations`
+	Type of `AzureResourceEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `CasesAggregation.Kind` has been changed from `Kind` to `KindBasicAggregations`
+	Type of `CloudApplicationEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `DNSEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `Entity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `FileEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `FileHashEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `HostEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `HuntingBookmark.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `IPEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `IoTDeviceEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `MailClusterEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `MailMessageEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `MailboxEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `MalwareEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `ProcessEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `RegistryKeyEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `RegistryValueEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `SecurityAlert.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `SecurityGroupEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `SubmissionMailEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `URLEntity.Kind` has been changed from `KindBasicEntity` to `Kind`

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 1f744ab67c98739aedfdf4c311e5e666f96dd7af. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityInsights [View full logs] [Preview SDK Changes]
- Microsoft.Azure.Management.SecurityInsights.1.0.0.nupkg
- Microsoft.Azure.Management.SecurityInsights.1.0.0.symbols.nupkg

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 1f744ab67c98739aedfdf4c311e5e666f96dd7af. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️securityinsight/mgmt/v1.0/securityinsight [View full logs] [Preview SDK Changes] Breaking Change Detected
```
info	[Changelog] This package was removed
```
️✔️securityinsight/mgmt/2020-01-01/securityinsight [View full logs]
```
info	[Changelog] No exported changes
```

️✔️preview/securityinsight/mgmt/2019-01-01-preview/securityinsight [View full logs] Breaking Change Detected

Only show 40 items here, please refer to log for details.

info	[Changelog] - New function `EyesOn.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New function `IPGeodataClient.GetPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `Anomalies.AsUeba() (*Ueba, bool)`
info	[Changelog] - New function `DomainWhoisClient.GetPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `NewIPGeodataClientWithBaseURI(string, string) IPGeodataClient`
info	[Changelog] - New function `PossibleKindBasicAggregationsValues() []KindBasicAggregations`
info	[Changelog] - New function `AnomaliesProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `Anomalies.AsEyesOn() (*EyesOn, bool)`
info	[Changelog] - New function `Anomalies.AsBasicSettings() (BasicSettings, bool)`
info	[Changelog] - New function `NewIPGeodataClient(string) IPGeodataClient`
info	[Changelog] - New function `Anomalies.AsEntityAnalytics() (*EntityAnalytics, bool)`
info	[Changelog] - New function `Anomalies.AsSettings() (*Settings, bool)`
info	[Changelog] - New function `Anomalies.AsIPSyncer() (*IPSyncer, bool)`
info	[Changelog] - New function `IPGeodataClient.Get(context.Context, string, string) (EnrichmentIPGeodata, error)`
info	[Changelog] - New function `Ueba.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New function `IPGeodataClient.GetResponder(*http.Response) (EnrichmentIPGeodata, error)`
info	[Changelog] - New function `Settings.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New function `DomainWhoisClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `DomainWhoisClient.Get(context.Context, string, string) (EnrichmentDomainWhois, error)`
info	[Changelog] - New function `DomainWhoisClient.GetResponder(*http.Response) (EnrichmentDomainWhois, error)`
info	[Changelog] - New function `IPGeodataClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `NewDomainWhoisClient(string) DomainWhoisClient`
info	[Changelog] - New function `Anomalies.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*Anomalies.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `NewDomainWhoisClientWithBaseURI(string, string) DomainWhoisClient`
info	[Changelog] - New function `IPSyncer.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New function `EntityAnalytics.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New struct `Anomalies`
info	[Changelog] - New struct `AnomaliesProperties`
info	[Changelog] - New struct `DomainWhoisClient`
info	[Changelog] - New struct `EnrichmentDomainWhois`
info	[Changelog] - New struct `EnrichmentDomainWhoisContact`
info	[Changelog] - New struct `EnrichmentDomainWhoisContacts`
info	[Changelog] - New struct `EnrichmentDomainWhoisDetails`
info	[Changelog] - New struct `EnrichmentDomainWhoisRegistrarDetails`
info	[Changelog] - New struct `EnrichmentIPGeodata`
info	[Changelog] - New struct `IPGeodataClient`
info	[Changelog]
info	[Changelog] Total 52 breaking change(s), 75 additive change(s).
info	[Changelog]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 1f744ab67c98739aedfdf4c311e5e666f96dd7af. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-securityinsight [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Operation has a new parameter origin
info	[Changelog]   - Model Bookmark has a new parameter query_start_time
info	[Changelog]   - Model Bookmark has a new parameter query_end_time
info	[Changelog]   - Model Bookmark has a new parameter event_time
info	[Changelog]   - Model TIDataConnector has a new parameter tip_lookback_period
info	[Changelog]   - Added operation ActionsOperations.create_or_update
info	[Changelog]   - Added operation ActionsOperations.delete
info	[Changelog]   - Added operation ActionsOperations.get
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation IncidentCommentsOperations.create_comment has a new signature
info	[Changelog]   - Parameter trigger_uri of model ActionRequestProperties is now required
info	[Changelog]   - Removed operation AlertRulesOperations.create_or_update_action
info	[Changelog]   - Removed operation AlertRulesOperations.delete_action
info	[Changelog]   - Removed operation AlertRulesOperations.get_action
info	[Changelog]   - Model OfficeDataConnectorDataTypes has a new signature

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 1f744ab67c98739aedfdf4c311e5e666f96dd7af. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md

️✔️@azure/arm-securityinsight [View full logs] [Preview SDK Changes]

azure-arm-securityinsight-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/securityInsights.js → ./dist/arm-securityinsight.js...
cmderr	[npmPack] created ./dist/arm-securityinsight.js in 377ms

️️✔️ azure-cli-extensions succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 1f744ab67c98739aedfdf4c311e5e666f96dd7af. Azure CLI Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-teams' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /Actions/put/Creates or updates an action of alert rule.
cmderr	[Autorest]     - name: /Actions/get/Get all actions of alert rule.
cmderr	[Autorest]     - name: /Actions/get/Get an action of alert rule.
cmderr	[Autorest]     - name: /Actions/delete/Delete an action of alert rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a Fusion alert rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a Scheduled alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a Fusion alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a Scheduled alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get all alert rules.
cmderr	[Autorest]     - name: /AlertRules/delete/Delete an alert rule.
cmderr	[Autorest]     - name: /AlertRuleTemplates/get/Get alert rule template by Id.
cmderr	[Autorest]     - name: /AlertRuleTemplates/get/Get all alert rule templates.
cmderr	[Autorest]     - name: /Bookmarks/put/Creates or updates a bookmark.
cmderr	[Autorest]     - name: /Bookmarks/get/Get a bookmark.
cmderr	[Autorest]     - name: /Bookmarks/get/Get all bookmarks.
cmderr	[Autorest]     - name: /Bookmarks/delete/Delete a bookmark.
cmderr	[Autorest]     - name: /DataConnectors/put/Creates or updates an Office365 data connector.
cmderr	[Autorest]     - name: /DataConnectors/put/Creates or updates an Threat Intelligence Platform data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get a ASC data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get a MCAS data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get a MDATP data connector
cmderr	[Autorest]     - name: /DataConnectors/get/Get a TI data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get all data connectors.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an AAD data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an AATP data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an AwsCloudTrail data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an Office365 data connector.
cmderr	[Autorest]     - name: /DataConnectors/delete/Delete an Office365 data connector.
cmderr	[Autorest]     - name: /IncidentComments/put/Creates an incident comment.
cmderr	[Autorest]     - name: /IncidentComments/get/Get all incident comments.
cmderr	[Autorest]     - name: /IncidentComments/get/Get an incident comment.
cmderr	[Autorest]     - name: /Incidents/put/Creates or updates an incident.
cmderr	[Autorest]     - name: /Incidents/get/Get all incidents.
cmderr	[Autorest]     - name: /Incidents/get/Get an incident.
cmderr	[Autorest]     - name: /Incidents/delete/Delete an incident.
cmderr	[Autorest] --------------------------------------------------------

️✔️securityinsight [View full logs] [Preview Azure CLI Changes]
- sentinel-0.1.0-py3-none-any.whl
- sentinel-0.1.0.zip

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 1f744ab67c98739aedfdf4c311e5e666f96dd7af. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️securityinsights [View full logs] [Preview Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-08-18T15:07:05Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-workflow-bot · 2021-08-18T15:08:56Z

Hi @laithhisham, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

laithhisham added 2 commits August 18, 2021 17:59

add AlertRules to 2021-04-01 stable API version

354a559

add examples for actions

30a19ca

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Aug 18, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Aug 18, 2021

openapi-sdkautomation bot mentioned this pull request Aug 18, 2021

[AutoPR Microsoft.Azure.Management.SecurityInsights] [Hub Generated] Review request for Microsoft.SecurityInsights to add version stable/2021-04-01 AzureSDKAutomation/azure-sdk-for-net#5561

Draft

openapi-pipeline-app bot added the CI-BreakingChange-Go label Aug 18, 2021

Update readme.md

d1a2015

openapi-sdkautomation bot mentioned this pull request Aug 18, 2021

[AutoPR securityinsights] [Hub Generated] Review request for Microsoft.SecurityInsights to add version stable/2021-04-01 AzureSDKAutomation/azure-resource-manager-schemas#4483

Draft

laithhisham added 3 commits August 19, 2021 08:53

add cloud error definition to align with other swagger files

874f7c6

add type to cloud error in TI

0a8f6c0

add type to IncidentAlertList

2f1edce

laithhisham closed this Nov 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.SecurityInsights to add version stable/2021-04-01 #15692

[Hub Generated] Review request for Microsoft.SecurityInsights to add version stable/2021-04-01 #15692

laithhisham commented Aug 18, 2021

openapi-workflow-bot bot commented Aug 18, 2021

openapi-pipeline-app bot commented Aug 18, 2021 •

edited

Loading

openapi-pipeline-app bot commented Aug 18, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Aug 18, 2021

openapi-workflow-bot bot commented Aug 18, 2021

[Hub Generated] Review request for Microsoft.SecurityInsights to add version stable/2021-04-01 #15692

[Hub Generated] Review request for Microsoft.SecurityInsights to add version stable/2021-04-01 #15692

Conversation

laithhisham commented Aug 18, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Aug 18, 2021

openapi-pipeline-app bot commented Aug 18, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Aug 18, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Aug 18, 2021

openapi-workflow-bot bot commented Aug 18, 2021

openapi-pipeline-app bot commented Aug 18, 2021 •

edited

Loading

openapi-pipeline-app bot commented Aug 18, 2021 •

edited

Loading