Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable mypy for some mgmt libraries #38904

Open
kristapratico opened this issue Dec 17, 2024 · 2 comments
Open

enable mypy for some mgmt libraries #38904

kristapratico opened this issue Dec 17, 2024 · 2 comments
Assignees
Labels
Mgmt This issue is related to a management-plane library. mypy

Comments

@kristapratico
Copy link
Member

Enable mypy for some of the larger mgmt libraries. Currently all mgmt is skipped for mypy due to this filter in the environment exclusions:

def is_typing_ignored(package_name: str) -> bool:
"""
Evaluates a package name and evaluates whether or not this package should be ignored when invoking type checking.
"""
if package_name in IGNORE_PACKAGES:
return True
if package_name not in FILTER_EXCLUSIONS and any([identifier in package_name for identifier in IGNORE_FILTER]):
return True
return False

We should remove the mgmt filter from this check and instead enable/disable per library pyproject.toml. Additionally, analyze weekly pipelines should be added for each so that we can track mypy errors through the bot opened issues in the future.

@kristapratico kristapratico added the Mgmt This issue is related to a management-plane library. label Dec 17, 2024
@kristapratico kristapratico self-assigned this Dec 17, 2024
@kristapratico
Copy link
Member Author

Start with: compute, storage, keyvault, resource, authorization, network

@kristapratico
Copy link
Member Author

The following checks also skip mgmt. Do we want to consider enabling in a similar fashion?

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library. mypy
Projects
None yet
Development

No branches or pull requests

1 participant