From a0f77965fa83337e4b7a33e54c727fd849a22579 Mon Sep 17 00:00:00 2001 From: Pankaj Agrawal Date: Fri, 13 Dec 2024 11:51:57 +0100 Subject: [PATCH] chore: lower case kind value to avoid diff everytime (#3911) ## Description Closes #3909 ## Pipeline Reference | Pipeline | | -------- | | [![avm.res.web.serverfarm](https://github.com/pankajagrawal16/bicep-registry-modules/actions/workflows/avm.res.web.serverfarm.yml/badge.svg?branch=3909%2Flowecase-kind)](https://github.com/pankajagrawal16/bicep-registry-modules/actions/workflows/avm.res.web.serverfarm.yml) | ## Type of Change - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [x] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings Co-authored-by: Buddy <38195643+tsc-buddy@users.noreply.github.com> --- avm/res/web/serverfarm/README.md | 26 +++++++++---------- avm/res/web/serverfarm/main.bicep | 14 +++++----- avm/res/web/serverfarm/main.json | 18 ++++++------- .../serverfarm/tests/e2e/max/main.test.bicep | 2 +- .../tests/e2e/waf-aligned/main.test.bicep | 2 +- avm/res/web/serverfarm/version.json | 4 +-- 6 files changed, 33 insertions(+), 33 deletions(-) diff --git a/avm/res/web/serverfarm/README.md b/avm/res/web/serverfarm/README.md index 4ae5c24824..8e12935b40 100644 --- a/avm/res/web/serverfarm/README.md +++ b/avm/res/web/serverfarm/README.md @@ -125,7 +125,7 @@ module serverfarm 'br/public:avm/res/web/serverfarm:' = { workspaceResourceId: '' } ] - kind: 'App' + kind: 'app' location: '' lock: { kind: 'CanNotDelete' @@ -197,7 +197,7 @@ module serverfarm 'br/public:avm/res/web/serverfarm:' = { ] }, "kind": { - "value": "App" + "value": "app" }, "location": { "value": "" @@ -279,7 +279,7 @@ param diagnosticSettings = [ workspaceResourceId: '' } ] -param kind = 'App' +param kind = 'app' param location = '' param lock = { kind: 'CanNotDelete' @@ -348,7 +348,7 @@ module serverfarm 'br/public:avm/res/web/serverfarm:' = { workspaceResourceId: '' } ] - kind: 'App' + kind: 'app' location: '' lock: { kind: 'CanNotDelete' @@ -400,7 +400,7 @@ module serverfarm 'br/public:avm/res/web/serverfarm:' = { ] }, "kind": { - "value": "App" + "value": "app" }, "location": { "value": "" @@ -458,7 +458,7 @@ param diagnosticSettings = [ workspaceResourceId: '' } ] -param kind = 'App' +param kind = 'app' param location = '' param lock = { kind: 'CanNotDelete' @@ -526,7 +526,7 @@ Defaults to false when creating Windows/app App Service Plan. Required if creati - Required: No - Type: bool -- Default: `[equals(parameters('kind'), 'Linux')]` +- Default: `[equals(parameters('kind'), 'linux')]` ### Parameter: `appServiceEnvironmentId` @@ -667,15 +667,15 @@ Kind of server OS. - Required: No - Type: string -- Default: `'App'` +- Default: `'app'` - Allowed: ```Bicep [ - 'App' - 'Elastic' - 'FunctionApp' - 'Linux' - 'Windows' + 'app' + 'elastic' + 'functionApp' + 'linux' + 'windows' ] ``` diff --git a/avm/res/web/serverfarm/main.bicep b/avm/res/web/serverfarm/main.bicep index 38bbc58e65..d95bcae4ea 100644 --- a/avm/res/web/serverfarm/main.bicep +++ b/avm/res/web/serverfarm/main.bicep @@ -27,16 +27,16 @@ param location string = resourceGroup().location @description('Optional. Kind of server OS.') @allowed([ - 'App' - 'Elastic' - 'FunctionApp' - 'Windows' - 'Linux' + 'app' + 'elastic' + 'functionApp' + 'windows' + 'linux' ]) -param kind string = 'App' +param kind string = 'app' @description('Conditional. Defaults to false when creating Windows/app App Service Plan. Required if creating a Linux App Service Plan and must be set to true.') -param reserved bool = (kind == 'Linux') +param reserved bool = (kind == 'linux') @description('Optional. The Resource ID of the App Service Environment to use for the App Service Plan.') param appServiceEnvironmentId string = '' diff --git a/avm/res/web/serverfarm/main.json b/avm/res/web/serverfarm/main.json index c339dd10ee..fe10fc7ecc 100644 --- a/avm/res/web/serverfarm/main.json +++ b/avm/res/web/serverfarm/main.json @@ -5,8 +5,8 @@ "metadata": { "_generator": { "name": "bicep", - "version": "0.30.23.60470", - "templateHash": "136819997431198276" + "version": "0.32.4.45862", + "templateHash": "13694467319022455305" }, "name": "App Service Plan", "description": "This module deploys an App Service Plan.", @@ -232,13 +232,13 @@ }, "kind": { "type": "string", - "defaultValue": "App", + "defaultValue": "app", "allowedValues": [ - "App", - "Elastic", - "FunctionApp", - "Windows", - "Linux" + "app", + "elastic", + "functionApp", + "windows", + "linux" ], "metadata": { "description": "Optional. Kind of server OS." @@ -246,7 +246,7 @@ }, "reserved": { "type": "bool", - "defaultValue": "[equals(parameters('kind'), 'Linux')]", + "defaultValue": "[equals(parameters('kind'), 'linux')]", "metadata": { "description": "Conditional. Defaults to false when creating Windows/app App Service Plan. Required if creating a Linux App Service Plan and must be set to true." } diff --git a/avm/res/web/serverfarm/tests/e2e/max/main.test.bicep b/avm/res/web/serverfarm/tests/e2e/max/main.test.bicep index 374c5887ee..42c8180a88 100644 --- a/avm/res/web/serverfarm/tests/e2e/max/main.test.bicep +++ b/avm/res/web/serverfarm/tests/e2e/max/main.test.bicep @@ -68,7 +68,7 @@ module testDeployment '../../../main.bicep' = [ skuCapacity: 3 perSiteScaling: true zoneRedundant: true - kind: 'App' + kind: 'app' lock: { name: 'lock' kind: 'CanNotDelete' diff --git a/avm/res/web/serverfarm/tests/e2e/waf-aligned/main.test.bicep b/avm/res/web/serverfarm/tests/e2e/waf-aligned/main.test.bicep index 3e0e62dd53..262856d035 100644 --- a/avm/res/web/serverfarm/tests/e2e/waf-aligned/main.test.bicep +++ b/avm/res/web/serverfarm/tests/e2e/waf-aligned/main.test.bicep @@ -58,7 +58,7 @@ module testDeployment '../../../main.bicep' = [ skuName: 'P1v3' skuCapacity: 3 zoneRedundant: true - kind: 'App' + kind: 'app' lock: { name: 'lock' kind: 'CanNotDelete' diff --git a/avm/res/web/serverfarm/version.json b/avm/res/web/serverfarm/version.json index 76049e1c4a..aa34c4d0f5 100644 --- a/avm/res/web/serverfarm/version.json +++ b/avm/res/web/serverfarm/version.json @@ -1,7 +1,7 @@ { "$schema": "https://aka.ms/bicep-registry-module-version-file-schema#", - "version": "0.3", + "version": "0.4", "pathFilters": [ "./main.json" ] -} \ No newline at end of file +}