Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Add support for PowerShell Core 'PowerShell72' as a Automation Runbook type #1743

Closed
1 task done
vipulkelkar opened this issue Apr 24, 2024 · 6 comments · Fixed by #1834
Closed
1 task done
Assignees
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@vipulkelkar
Copy link

vipulkelkar commented Apr 24, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/automation/automation-account

(Optional) Module Version

0.4.1

Description

Creation of 'PowerShell core' runbook is now supported through Azure Bicep, refer runbookType

The AVM module for Automation Account, does not support "PowerShell72" as a runbook type. The allowed values at the moment are as below and the module fails when 'PowerShell72' is supplied as a type

'The provided value for the template parameter 'type' is not valid. The value 'PowerShell72' is not part of the allowed value(s):

[
'Graph'
'GraphPowerShell'
'GraphPowerShellWorkflow'
'PowerShell'
'PowerShellWorkflow'
]

(Optional) Correlation Id

No response

@vipulkelkar vipulkelkar added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Apr 24, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Note

This label was added as per ITA06.

Note

The "Type: Feature Request ➕" label was added as per ITA20.

Copy link

@vipulkelkar, thanks for submitting this issue for the avm/res/automation/automation-account module!

Important

A member of the @azure/avm-res-automation-automationaccount-module-owners-bicep or @azure/avm-res-automation-automationaccount-module-contributors-bicep team will review it soon!

@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Apr 24, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Apr 24, 2024

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

Note

This message was posted as per ITA01BCP.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Apr 29, 2024
@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Apr 29, 2024

Hey @elanzel, could you please take a look at your earliest convenience? Sounds like a valid ask & quick update :)

@elanzel
Copy link
Contributor

elanzel commented May 3, 2024

Hi, i'm doing it

@elanzel elanzel removed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels May 3, 2024
@github-project-automation github-project-automation bot moved this from Needs: Triage to Done in AVM - Module Issues May 3, 2024
hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this issue Jun 19, 2024
…ok type (Azure#1834)

## Description
- updated runbook API version t 2023-11-01 to support all the following
runbook types:
'Graph'
'GraphPowerShell'
'GraphPowerShellWorkflow'
'PowerShell'
'PowerShell72'
'PowerShellWorkflow'
'Python2'
'Python3'
'Script' (required)
- updated useridentity and keyservices to be compliant with new bicep
requirements
- updated PSRule excemption file for default checks

Closes Azure#1757 
Closes Azure#1743 
Closes Azure#1445 

## Pipeline Reference

| Pipeline |
| -------- |

[![avm.res.automation.automation-account](https://github.com/elanzel/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml/badge.svg?branch=automationaccount)](https://github.com/elanzel/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml)
|          |

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [X] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

---------

Co-authored-by: Alexander Sehr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
3 participants