Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump go version to 1.21 #303

Closed
wants to merge 33 commits into from
Closed

feat: Bump go version to 1.21 #303

wants to merge 33 commits into from

Commits on Mar 18, 2024

  1. feat: bump go version

    ishaansehgal99 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    81fb954 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Configuration menu
    Copy the full SHA
    723b228 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d0498a0 View commit details
    Browse the repository at this point in the history
  3. ci: Update pipeline target

    Signed-off-by: Heba <[email protected]>
    helayoty authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    e1673aa View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. docs: Update README.md for announcing v0.2.1 (#307)

    Signed-off-by: Fei Guo <[email protected]>
    Fei-Guo authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2485c58 View commit details
    Browse the repository at this point in the history
  2. feat: Part 2 - Add validation checks for TuningSpec, DataSource, Data…

    …Destination (#304)
    
    Open to feedback. Here is validation checks for the new CRD.
    
    Code Coverage: 87.7% - workspace_validation.go
    
    
    [coverage.txt](https://github.com/Azure/kaito/files/14661460/coverage.txt)
    ishaansehgal99 authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4ba337d View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. fix: Fix typo in Makefile (#315)

    I'm assuming this should be `.PHONY` not `.PHONE`
    
    Signed-off-by: Dave Fellows <[email protected]>
    davefellows authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e69f8bf View commit details
    Browse the repository at this point in the history
  2. docs: Update README.md to correct the mail list (#317)

    Correct the mail list name.
    
    Fix issue #314
    
    Signed-off-by: Fei Guo <[email protected]>
    Fei-Guo authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    10af81a View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. chore: Add GitHub issue/PR templates (#316)

    - Add report bug template
    - Add feature request template
    - Add PR template
    
    Signed-off-by: Heba Elayoty <[email protected]>
    helayoty authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    2f0323a View commit details
    Browse the repository at this point in the history
  2. fix: Adjust default model params (#310)

    Signed-off-by: Ishaan Sehgal <[email protected]>
    Co-authored-by: Fei Guo <[email protected]>
    ishaansehgal99 and Fei-Guo authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    99b7d57 View commit details
    Browse the repository at this point in the history
  3. fix: Update Model Tags (#311)

    Signed-off-by: Ishaan Sehgal <[email protected]>
    ishaansehgal99 authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    8eddac3 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. ci: Update release workflow (#319)

    **Reason for Change**:
    - Automate the release workflow.
    - Use [Reusable
    workflows](https://docs.github.com/en/actions/using-workflows/reusing-workflows#reusable-workflows-and-starter-workflows)
    instead of workflow_dispatch. This will enhance the usability of e2e
    pipeline.
    - Remove unnecessary jobs.
    - Fix goreleaser to pick the current tag.
    - Add option to update k8s version for upcoming pipelines.
    
    **Requirements**
    - [ ] added unit tests and e2e tests (if applicable).
    
    **Issue Fixed**:
    <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next
    line. -->
    
    **Notes for Reviewers**:
    
    ---------
    
    Signed-off-by: Heba Elayoty <[email protected]>
    helayoty authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    d079f36 View commit details
    Browse the repository at this point in the history
  2. fix: Update helm chart to use Release.Namespace (#322)

    **Reason for Change**:
    Update helm chart to use `Release.Namespace` instead of chart name.
    
    **Requirements**
    
    - [ ] added unit tests and e2e tests (if applicable).
    
    **Issue Fixed**:
    <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next
    line. -->
    
    **Notes for Reviewers**:
    
    Signed-off-by: Heba Elayoty <[email protected]>
    helayoty authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    2df7725 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8d0976f View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. ci: Remove PR trigger from release workflow (#330)

    **Reason for Change**:
    Remove PR trigger from release workflow. As we follow a branch based
    approach.
    
    **Requirements**
    
    - [ ] added unit tests and e2e tests (if applicable).
    
    **Issue Fixed**:
    <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next
    line. -->
    
    **Notes for Reviewers**:
    
    Signed-off-by: Heba Elayoty <[email protected]>
    helayoty authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    c49b93a View commit details
    Browse the repository at this point in the history
  2. fix: Add registry as a pipeline job output (#329)

    **Reason for Change**:
    - The job output for registry was missing.
    - calling the output should use the job name, not step one.
    - 
    **Requirements**
    
    - [ ] added unit tests and e2e tests (if applicable).
    
    **Issue Fixed**:
    <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next
    line. -->
    
    **Notes for Reviewers**:
    
    ---------
    
    Signed-off-by: Heba <[email protected]>
    helayoty authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    ee9101a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    08dd1f4 View commit details
    Browse the repository at this point in the history
  4. feat: Add sample front end helm chart (#320)

    **Reason for Change**:
    This helm chart provides a straightforward example for deploying a
    sample UI on top of a kaito workspace.
    ishaansehgal99 authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    05fb90c View commit details
    Browse the repository at this point in the history
  5. feat: Add API Docs and Improve Inference Readability (#331)

    **Reason for Change**:
    This change adds plenty more documentation and OpenAPI spec for our
    inference. It also enables the use of preferred non-NVIDIA nodes without
    crashing.
    
    **Requirements**
    
    - [x] added unit tests and e2e tests (if applicable).
    
    **Issue Fixed**:
    Fixes #321 
    
    **Notes for Reviewers**:
    ishaansehgal99 authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    cf7cf94 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Configuration menu
    Copy the full SHA
    77aa95b View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. fix: Update namespace in the helm chart (#337)

    **Reason for Change**:
    - Update the namespace to use the release namespace.
    
    **Requirements**
    
    - [ ] added unit tests and e2e tests (if applicable).
    
    **Issue Fixed**:
    Fixes #336 
    **Notes for Reviewers**:
    
    ---------
    
    Signed-off-by: Heba <[email protected]>
    Co-authored-by: ishaansehgal99 <[email protected]>
    helayoty and ishaansehgal99 authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    fde6369 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. fix: Add preset nil checks (#347)

    **Reason for Change**:
    Address some missing needed nil checks in workspace controller
    ishaansehgal99 authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    64152d4 View commit details
    Browse the repository at this point in the history
  2. feat: Add default configmaps - Part 5 (#346)

    **Reason for Change**:
    Provide a default configmaps in the helm chart.
    
    **Notes for Reviewers**:
    An env variable release namespace is passed in for future use so that
    the controller will be able to find where the configmap is deployed.
    
    ---------
    
    Signed-off-by: Ishaan Sehgal <[email protected]>
    ishaansehgal99 authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f88b529 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. chore: Add utils functions and move tests into seperate package (#351)

    **Reason for Change**:
    Add some future needed util functions, and move tests to seperate
    package to prevent cyclical depdencies where API imports utils then
    utils imports API. In order to use utils in API need to seperate out
    test logic.
    ishaansehgal99 authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9e2ac24 View commit details
    Browse the repository at this point in the history
  2. feat: Add global client, accessible via webhooks (#353)

    **Reason for Change**:
    Add global client, accessible via webhooks
    
    In this PR I also
    Separate setup and execution phase of webhook server, allows us to
    handle setup errors and setup context before attempting to run the
    webhook server
    ishaansehgal99 authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e2f5e25 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. chore: naming nit preset-inferences.go

    Signed-off-by: Ishaan Sehgal <[email protected]>
    ishaansehgal99 authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    65a99da View commit details
    Browse the repository at this point in the history
  2. feat: Add few util functions (#354)

    **Reason for Change**:
    Add util function for configmapmount and getting release namespace.
    ishaansehgal99 authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e799d62 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. feat: Update CRD to add Volume and ConfigTemplate (#356)

    **Reason for Change**:
    This change removes hostPath field in DataSource and DataDestination
    struct. Instead, a standard K8s VolumeSource API is used to specify the
    volumes used by the tuning Job. This will provide the highest
    flexibility for users to load/store the data. HostPath field is hard to
    use in practice.
    
    This change also renames the Config to ConfigTemplate because the final
    configmap used by the tuning job will be generated by the controller
    based on the template. The new name is clearer.
    
    **Notes for Reviewers**:
    We will revisit how to do validation check for the Volume field because
    it is a fairly complicated API.
    Fei-Guo authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    bf4acba View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. feat: Simple Configmap Validation Checks - Part 6 (#355)

    **Reason for Change**:
    This PR adds two simple checks to the tuning configmap - makes sure
    based on the method specified (LoRa or QLoRa) the correct params are
    included. Also checks to make sure all the sections specified in the
    configmap are recognized.
    ishaansehgal99 authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    6be8a0d View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. feat: Setup Preset Tuning Util Functions and miscellaneous validation…

    …/logging - Part 7 (#358)
    
    **Reason for Change**:
    This PR introduces some of the util functions that are to be used by the
    function
    
    func CreatePresetTuning(ctx context.Context, workspaceObj
    *kaitov1alpha1.Workspace,
    tuningObj *model.PresetParam, kubeClient client.Client) (client.Object,
    error)
    	
    
    This function will be in charge of handling launching the training job
    using the dataset source and uploading results to dataset destination.
    It is also incharge of ensuring configmap tuning parameters are in the
    right namespace so they are ready to be used by the fine_tuning_api.py
    file.
    ishaansehgal99 authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0b63598 View commit details
    Browse the repository at this point in the history
  2. feat: [SKU modularization] sku handler interface (#357)

    **Reason for Change**:
    Adding a CloudSKUHandler interface that will be used to modularize gpu
    skus across multiple cloud platforms
    
    **Requirements**
    
    - [ ] added unit tests and e2e tests (if applicable).
    
    **Issue Fixed**:
    <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next
    line. -->
    
    **Notes for Reviewers**:
    The cloud specific implementations and fixes/updates to current code
    will be part of future PRs.
    smritidahal653 authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    aa89d20 View commit details
    Browse the repository at this point in the history
  3. test: Add UTs for invalid image source or destination (#359)

    **Reason for Change**:
    Couple UTs added
    
    **Requirements**
    
    - [ x] added unit tests and e2e tests (if applicable).
    ishaansehgal99 authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9342647 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c2614a2 View commit details
    Browse the repository at this point in the history