Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: Apply security best practices #318

Merged
merged 4 commits into from
May 3, 2024
Merged

Conversation

helayoty
Copy link
Collaborator

Fixes #313

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.64%. Comparing base (fde6369) to head (145466b).
Report is 19 commits behind head on main.

❗ Current head 145466b differs from pull request most recent head 1025201. Consider uploading reports for the commit 1025201 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
+ Coverage   62.89%   64.64%   +1.75%     
==========================================
  Files          14       29      +15     
  Lines        1307     2130     +823     
==========================================
+ Hits          822     1377     +555     
- Misses        447      686     +239     
- Partials       38       67      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, just minor FYI comment. I think most will be step security wizard generated, also, we can also add depdenabot if that not enabled for future ease.

Signed-off-by: Heba Elayoty <[email protected]>
Signed-off-by: Heba Elayoty <[email protected]>
@helayoty helayoty merged commit 667d426 into main May 3, 2024
4 of 6 checks passed
@helayoty helayoty deleted the helayoty/security-fixes branch May 3, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants