Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for route tables & routes #376

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kewalaka
Copy link
Contributor

@kewalaka kewalaka commented May 5, 2024

Overview/summary

This introduces support for route tables & routes. It has been added to support the default route issue, but is generic so can be used to create any route table & route.

I have kept it pinned to azapi 1.11 noting the changes required to bump to 1.13.1

This PR fixes/adds/changes/removes

  1. fixes feat: 'default' udr for new subscriptions #218

Breaking changes

n/a new change

Testing evidence

I have tested this on my integration branch here, based on the following inputs (and no input)

image

deployed;

image

As part of this pull request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Run and make fmt & make docs to format your code and update documentation.
  • Created unit and deployment tests and provided evidence. edit - yes to deployment tests
  • Updated relevant and associated documentation.

I'm not familiar with the unit test approach, guidance would be appreciated 😊

@kewalaka kewalaka requested a review from a team as a code owner May 5, 2024 03:07
@kewalaka kewalaka changed the title support for route tables & routes feat: support for route tables & routes May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 'default' udr for new subscriptions
1 participant