Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for node_modules #425

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

camara-tech
Copy link

GitHub is now discouraging checking in the node_modules folder. Also, there are times when a dependency in that folder will flag enterprise virus scanners, preventing the action from running on a self-hosted GitHub runner.

This PR

  • Configures npm run bundle with @vercel/ncc, eliminating the need for including the node_modules in a release.
  • Adds the dist/ folder with the javascript bundled by NCC for the next release of the action
  • Updates the action configuration to use the bundled javascript from NCC.
  • Tweaks the README.md to include the SVG logo
  • Updates the GitHub Workflows to eliminate deprecation warnings

https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action

@camara-tech
Copy link
Author

camara-tech commented Jun 18, 2024

@microsoft-github-policy-service agree company="Improving"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants