Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoking AzureResourceFilterUtility.getAppDetails with slotname (releases/v3) #433

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

ShilpiRachna1
Copy link
Collaborator

@ShilpiRachna1 ShilpiRachna1 commented Aug 1, 2024

This PR has the following changes:

Updated version of package azure-actions-appservice-rest to 1.3.16 which has the support for querying slot app service.
Calling AzureResourceFilterUtility.getAppDetails with slotname
All other changes are due to npm run build

Testing
Tested by deploying to all the slots of web app https://ms.portal.azure.com/#@microsoft.onmicrosoft.com/resource/subscriptions/bef29afb-3c08-4894-ae64-43bdd8f3f447/resourceGroups/kudulitemanthantestingcoverage/providers/Microsoft.Web/sites/GHA-shilpir/deploymentSlotsV2 from the source branch.

The 2 slots in the test app are setup with basic auth and federated credentials

Master branch PR: #429

Copy link
Member

@surenderssm surenderssm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@kumaraksh1 kumaraksh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ShilpiRachna1 ShilpiRachna1 merged commit 2fdd5c3 into releases/v3 Aug 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants