Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate log keyID for IDX10503 #2604

Open
RetYn opened this issue May 22, 2024 · 1 comment · May be fixed by #2899
Open

Duplicate log keyID for IDX10503 #2604

RetYn opened this issue May 22, 2024 · 1 comment · May be fixed by #2899
Labels
Good First Issue This is a good item for new team members
Milestone
8.3.1

Comments

@RetYn
Copy link

RetYn commented May 22, 2024 •
edited
Loading

Summary

The log message for IDX10503 in this https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2436/files is duplicated:
image
key.ToString already contains the key.keyId in it.
https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/dev/src/Microsoft.IdentityModel.Tokens/SecurityKey.cs
image

In addition, I don't think it's necessary to print the InternalId which is the thumbprints of the public key in the log.
@RetYn RetYn changed the title Duplicate log message for IDX10503 Duplicate log key ID for IDX10503 May 22, 2024
@RetYn RetYn changed the title Duplicate log key ID for IDX10503 Duplicate log keyID for IDX10503 May 22, 2024
@kellyyangsong kellyyangsong added the Good First Issue This is a good item for new team members label May 31, 2024
@bdapoigny
Copy link

Can i work on it ? @kellyyangsong

@bdapoigny bdapoigny linked a pull request Oct 11, 2024 that will close this issue
Open
@pmaytak pmaytak added this to the 8.2.0 milestone Nov 1, 2024
@jennyf19 jennyf19 modified the milestones: 8.2.0, 8.2.1 Nov 2, 2024
@pmaytak pmaytak modified the milestones: 8.2.1, 8.3.0 Nov 14, 2024
@jennyf19 jennyf19 modified the milestones: 8.3.0, 8.3.1 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue This is a good item for new team members
Projects
None yet
Milestone
8.3.1
5 participants
@RetYn @jennyf19 @pmaytak @bdapoigny @kellyyangsong