Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to C# 13 #2998

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Upgrade to C# 13 #2998

merged 4 commits into from
Jan 6, 2025

Conversation

westin-m
Copy link
Contributor

increment to C# 13

@westin-m westin-m requested a review from a team as a code owner November 12, 2024 21:21
jennyf19
jennyf19 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@westin-m westin-m linked an issue Nov 14, 2024 that may be closed by this pull request
[Feature Request] Update to C#13 when .NET 9 ships #2933
Closed
@pmaytak pmaytak requested a review from Copilot December 20, 2024 21:49
Copilot
Copilot AI reviewed Dec 20, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (4)
  • benchmark/Microsoft.IdentityModel.Benchmarks/Microsoft.IdentityModel.Benchmarks.csproj: Language not supported
  • build/common.props: Language not supported
  • build/commonTest.props: Language not supported
  • test/Microsoft.IdentityModel.AotCompatibility.Tests/Microsoft.IdentityModel.AotCompatibility.Tests.csproj: Language not supported
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Summary

Summary
Generated on: 1/6/2025 - 5:24:28 PM
Coverage date: 1/6/2025 - 5:14:38 PM - 1/6/2025 - 5:24:01 PM
Parser: MultiReport (60x Cobertura)
Assemblies: 1
Classes: 7
Files: 2
Line coverage: 80.3% (620 of 772)
Covered lines: 620
Uncovered lines: 152
Coverable lines: 772
Total lines: 483
Branch coverage: 67.8% (228 of 336)
Covered branches: 228
Total branches: 336
Method coverage: Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%
Name Line Branch
Microsoft.IdentityModel.JsonWebTokens 80.3% 67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities 100%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0		 81.4% 67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0		 81.4% 67.6%

@westin-m westin-m added this to the 8.3.1 milestone Jan 6, 2025
@westin-m westin-m merged commit 0aeeb26 into dev Jan 6, 2025
6 checks passed
@westin-m westin-m deleted the westin/csharp13 branch January 6, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@msbw2 msbw2 msbw2 approved these changes

@pmaytak pmaytak pmaytak approved these changes

@jennyf19 jennyf19 jennyf19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.3.2
Development

Successfully merging this pull request may close these issues.

[Feature Request] Update to C#13 when .NET 9 ships
4 participants
@westin-m @jennyf19 @pmaytak @msbw2