Hackathon: msal-browser - Replaced sinon with jest #7337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbie-Microsoft
requested review from
sameerag,
tnorling,
hectormmg,
jo-arroyo,
peterzenz,
konstantin-msft,
lalimasharda,
shylasummers and
bgavrilMS
as code owners
lib/msal-browser/test/interaction_client/RedirectClient.spec.ts
Outdated
Show resolved
Hide resolved
lib/msal-browser/test/interaction_client/RedirectClient.spec.ts
Outdated
Show resolved
Hide resolved
lib/msal-browser/test/interaction_client/RedirectClient.spec.ts
Outdated
Show resolved
Hide resolved
lib/msal-browser/test/interaction_client/RedirectClient.spec.ts
Outdated
Show resolved
Hide resolved
konstantin-msft
approved these changes
Sep 27, 2024
tnorling
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used automated tooling to replace sinon with jest in all the msal-browser tests. The tooling did not work for
PublicClientApplication.ts, I had to do that one by hand. I re-ran every test in msal-browser and confirmed that they all still run successfully.