From 233f71e124fe5324bfae3be5175fab65f87cb901 Mon Sep 17 00:00:00 2001 From: Westin Musser <127992899+westin-m@users.noreply.github.com> Date: Thu, 24 Oct 2024 12:55:09 -0700 Subject: [PATCH] clean up --- .github/workflows/PR_comment.yml | 24 ------------------------ .github/workflows/dotnetcore.yml | 14 ++++---------- .github/workflows/summary.yml | 24 ------------------------ 3 files changed, 4 insertions(+), 58 deletions(-) delete mode 100644 .github/workflows/PR_comment.yml delete mode 100644 .github/workflows/summary.yml diff --git a/.github/workflows/PR_comment.yml b/.github/workflows/PR_comment.yml deleted file mode 100644 index 1b23f73c8..000000000 --- a/.github/workflows/PR_comment.yml +++ /dev/null @@ -1,24 +0,0 @@ -# on: pull_request -# permissions: write-all -# jobs: -# example_comment_pr: -# runs-on: windows-latest -# name: An example job to comment a PR -# steps: -# - name: Set comment content -# shell: bash -# run: | -# echo "Hello! Thanks for opening this PR." > data.txt -# echo "COMMENT_CONTENT=$(cat data.txt)" >> $GITHUB_ENV -# - name: Comment PR -# uses: actions/github-script@v7 -# id: comment - -# with: -# script: | -# github.rest.issues.createComment({ -# issue_number: context.issue.number, -# owner: context.repo.owner, -# repo: context.repo.repo, -# body: process.env.COMMENT_CONTENT -# }) \ No newline at end of file diff --git a/.github/workflows/dotnetcore.yml b/.github/workflows/dotnetcore.yml index 937cdffbe..5e3ff4f7f 100644 --- a/.github/workflows/dotnetcore.yml +++ b/.github/workflows/dotnetcore.yml @@ -62,23 +62,17 @@ jobs: dotnet tool install -g dotnet-reportgenerator-globaltool reportgenerator -reports:./**/coverage.cobertura.xml -targetdir:CodeCoverage -reporttypes:'MarkdownSummaryGithub;Cobertura' - - name: Write to Job Summary + - name: Write Coverage to Job Summary shell: bash run: cat CodeCoverage/SummaryGithub.md >> $GITHUB_STEP_SUMMARY - - name: Set comment content - shell: bash - run: | + - run: | echo "COMMENT_CONTENT_ENV_VAR<> $GITHUB_ENV echo $(cat CodeCoverage/SummaryGithub.md) >> $GITHUB_ENV echo "EOF" >> $GITHUB_ENV - # CONTENT=$(cat CodeCoverage/SummaryGithub.md) - # echo "COMMENT_CONTENT=$CONTENT" >> $GITHUB_ENV - # run: | - # cat CodeCoverage/SummaryGithub.md >> $COMMENT_CONTENT - # echo "COMMENT_CONTENT=$COMMENT_CONTENT" >> $GITHUB_ENV + shell: bash - - name: Comment PR + - name: Comment Coverage in PR uses: actions/github-script@v7 id: comment with: diff --git a/.github/workflows/summary.yml b/.github/workflows/summary.yml deleted file mode 100644 index 3f96b479e..000000000 --- a/.github/workflows/summary.yml +++ /dev/null @@ -1,24 +0,0 @@ -name: 'Summary example' - -on: - push: - branches: - - master - pull_request: - types: - - opened - - synchronize - - reopened - - ready_for_review - branches: - - master - -permissions: write-all - -jobs: - summary: - runs-on: windows-latest - steps: - - name: generate summary - shell: bash - run: echo "### Hello world! :rocket:" >> $GITHUB_STEP_SUMMARY \ No newline at end of file