Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failure in k3d visualization #108

Closed
marscher opened this issue Dec 7, 2023 · 5 comments
Closed

test failure in k3d visualization #108

marscher opened this issue Dec 7, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@marscher
Copy link
Contributor

marscher commented Dec 7, 2023

Some CS in test does not use coordinates, although all involved input CS, and data has units assigned.

_______________________________________ test_k3d_csm_vis _______________________________________
weldx_widgets/tests/test_k3d.py:30: in test_k3d_csm_vis
    plot = CoordinateSystemManagerVisualizerK3D(csm=csm)
weldx_widgets/visualization/csm_k3d.py:659: in __init__
    limits = self._get_limits()
weldx_widgets/visualization/csm_k3d.py:698: in _get_limits
    limits_trace = self._get_limits_trace()
weldx_widgets/visualization/csm_k3d.py:693: in _get_limits_trace
    limits = np.stack([lcs_vis.limits() for lcs_vis in self._lcs_vis.values()])
../../miniforge3/envs/wx/lib/python3.12/site-packages/pint/facets/numpy/quantity.py:64: in __array_function__
    return numpy_wrap("function", func, args, kwargs, types)
../../miniforge3/envs/wx/lib/python3.12/site-packages/pint/facets/numpy/numpy_func.py:953: in numpy_wrap
    return handled[name](*args, **kwargs)
../../miniforge3/envs/wx/lib/python3.12/site-packages/pint/facets/numpy/numpy_func.py:575: in _stack
    arrays, output_wrap = unwrap_and_wrap_consistent_units(*arrays)
../../miniforge3/envs/wx/lib/python3.12/site-packages/pint/facets/numpy/numpy_func.py:130: in unwrap_and_wrap_consistent_units
    args, _ = convert_to_consistent_units(*args, pre_calc_units=first_input_units)
../../miniforge3/envs/wx/lib/python3.12/site-packages/pint/facets/numpy/numpy_func.py:111: in convert_to_consistent_units
    tuple(convert_arg(arg, pre_calc_units=pre_calc_units) for arg in args),
../../miniforge3/envs/wx/lib/python3.12/site-packages/pint/facets/numpy/numpy_func.py:111: in <genexpr>
    tuple(convert_arg(arg, pre_calc_units=pre_calc_units) for arg in args),
../../miniforge3/envs/wx/lib/python3.12/site-packages/pint/facets/numpy/numpy_func.py:93: in convert_arg
    raise DimensionalityError("dimensionless", pre_calc_units)
E   pint.errors.DimensionalityError: Cannot convert from 'dimensionless' to 'mm'
@marscher marscher added the bug Something isn't working label Dec 7, 2023
@CagtayFabry
Copy link
Member

found it: 8b5f6df

@marscher
Copy link
Contributor Author

Still there was a requirement to filter the warning after the min/max reduction of the coordinates during the limit computation and reattaching the unit to the result. I wanted to test a recent pint version as it seems that this operation is supported upstream, but we have pinned pint for some reason in weldx.

@marscher
Copy link
Contributor Author

marscher commented Dec 13, 2023

The pip release of weldx does not pin pint, so we install version 0.23 on CI.
The tests pass locally with version 0.20 installed.

@CagtayFabry
Copy link
Member

Still there was a requirement to filter the warning after the min/max reduction of the coordinates during the limit computation and reattaching the unit to the result. I wanted to test a recent pint version as it seems that this operation is supported upstream, but we have pinned pint for some reason in weldx.

So the warning comes from pint 0.23? I can't find it in the CI run https://github.com/BAMWelDX/weldx-widgets/actions/runs/7172922883/job/19531144572

@marscher
Copy link
Contributor Author

fixed by #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants