Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assumed file name may result in an error when generating naive maps #69

Open
petiay opened this issue Nov 5, 2021 · 1 comment
Open
Labels

Comments

@petiay
Copy link
Member

petiay commented Nov 5, 2021

(This is minor). Although the standard BEAST outputs are stored in a stats.fits file, referring to stats.fits in this line of make_naive_maps.py may result in an error if one has changed the name of the output file where stats.fits does not exist in a file name. (Actually the error I encountered ends up overwriting the very stats.fits file! )
For this reason I'd lobby for only referring to .fits instead of to stats.fits, unless values_per_pixel.hd5 without a preceding stats is an expected input somewhere else at this point and it's hard to change that.

@christinawlindberg
Copy link

I've run into this same issue, where, because my stats files had a suffix, the code just ends up overwriting my original file.

@karllark karllark added the bug label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants