Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Incorrect CLIF commented sentences #96

Open
mereolog opened this issue Aug 7, 2024 · 1 comment
Open

BUG: Incorrect CLIF commented sentences #96

mereolog opened this issue Aug 7, 2024 · 1 comment
Assignees
Labels
bug Something isn't working FOL staged The FOL source has been updated, but not yet published

Comments

@mereolog
Copy link

mereolog commented Aug 7, 2024

Describe the bug
IMHO, most if not all, CLIF files are syntactically incorrect as far as the use of CLIF commented sentences (commentsent) is concerned.

To Reproduce
According to the spec all CLIF comment elements, e.g., CLIF commentsent, require that the 'cl:comment' is followed by a quotedstring. And all quotedstrings are delimited by single quotes (stringquote), i.e., by '.
(I refer to ISO/IEC 24707:2018(E)).

Consider now https://github.com/BFO-ontology/BFO-2020/blob/master/src/common-logic/continuant-mereology.cl, in particular:

(cl:comment "continuant-part-of and has-continuant-part are inverse relations [eld-1]"
(forall (t a b)
(iff (continuant-part-of a b t) (has-continuant-part b a t))))

Since this CLIF element uses double quotes (namequote), it does not follow the ISO spec.
I guess that similar remarks can be made about all other commented sentences throughout other files.

Expected behaviour
All double quotes in commented sentences need to be replaced by single quotes (stringquote), using innerstringquote when needed.

@mereolog mereolog added the bug Something isn't working label Aug 7, 2024
@mereolog mereolog changed the title BUG: [TITLE SUMMARIZING ISSUE] BUG: Incorrect CLIF commented sentences Aug 7, 2024
@alanruttenberg
Copy link
Contributor

Thank you for the report. The source code has been fixed and the corrected version will appear in the next release.

@alanruttenberg alanruttenberg added the FOL staged The FOL source has been updated, but not yet published label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FOL staged The FOL source has been updated, but not yet published
Projects
None yet
Development

No branches or pull requests

3 participants