Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawners turning into 1 #989

Open
Tree182 opened this issue Dec 6, 2024 · 7 comments
Open

Spawners turning into 1 #989

Tree182 opened this issue Dec 6, 2024 · 7 comments
Assignees
Labels
📝 Missing information Required information is missing ❌ Unconfirmed Bugs that were reported but yet to be replicatable

Comments

@Tree182
Copy link

Tree182 commented Dec 6, 2024

Minecraft's Version

Paper 1.12.2

Plugin's Version

latest

Describe the bug

when players tp away from a stack of spawners, it sometimes (really unpredictably, I cant figure out how to reliably recreate it) but always randomly will just turn back into 1 spawner when the player returns.

The hologram completely goes and the server treats it like it is 1 spawner. This can be fixed by rebooting the server (tf the spawner isnt mined) then the stack comes back.

To Reproduce

when players tp away from a stack of spawners, it sometimes (really unpredictably, I cant figure out how to reliably recreate it) but always randomly will just turn back into 1 spawner when the player returns.

The hologram completely goes and the server treats it like it is 1 spawner. This can be fixed by rebooting the server (tf the spawner isnt mined) then the stack comes back.

Additional Information

n/a

@Tree182 Tree182 added the Pending Pending reports to be investigated label Dec 6, 2024
@OmerBenGera
Copy link
Member

I need more information about how to replicate it, otherwise I won't be able to help.

@OmerBenGera OmerBenGera added ❌ Unconfirmed Bugs that were reported but yet to be replicatable 📝 Missing information Required information is missing and removed Pending Pending reports to be investigated labels Dec 14, 2024
@Tree182
Copy link
Author

Tree182 commented Dec 14, 2024

Im not sure what to say? It seems to happen when the player changes worlds but even then, it seems unpredictable (sometimes it happens, sometimes not)
It seems like it's unloading the hologram and then just assuming that there isnt a stack there anymore when the chunks unload. But the odd thing is that it is still showing as the right amount in the .db file. Does it not check that when breaking? It seems it relies on the info from the hologram maybe?

@OmerBenGera
Copy link
Member

The hologram and all the data of spawners is cached in memory, and it does not check the DB for every action against a spawner (obviously, otherwise it will lag your server).
Keep trying to understand how to replicate it and report back.

@Tree182
Copy link
Author

Tree182 commented Dec 14, 2024

Well it seems like something is making it not read that cache.

Ive spent about a week trying to replicate it and it seems random as far as I can tell. I dont know the code so im not sure what else I can do.

Do you have any specific tests you want me to do? Or would you like the details to come take a look yourself?

@OmerBenGera
Copy link
Member

Well it seems like something is making it not read that cache.

Ive spent about a week trying to replicate it and it seems random as far as I can tell. I dont know the code so im not sure what else I can do.

Do you have any specific tests you want me to do? Or would you like the details to come take a look yourself?

I recommend trying it on a localhost server with only WildStacker installed.
Spawners are unloaded and loaded when chunks are unloaded and loaded, probably something related to that

@Tree182
Copy link
Author

Tree182 commented Dec 14, 2024

Ive tried that (not a local server but an empty server with only wildstacker)
The only remote consistency that I can seem to find is that every time it happens, it seems to be when the player changes worlds. So they go from the end to the overworld for example.

I think you are right about it being that event that loads the spawners, for some reason it isnt re-adding them into the cache or adding the hologram.

Ive spent like a week trying to figure this out. Im here as a last resort. I know I don't subscribe to your patreon but I did pay for this plugin originally when it was paid (search spigot for Tree182) so can you take a look at that part of the code maybe please? to see if theres some way its not being properly loaded? or maybe give me some steps to debug it?

Any help would be greatly appreciated.

@OmerBenGera
Copy link
Member

Any time a chunk is loaded the spawners are added to the cache. I can add debug messages but it will be spammy a bit.
What is your discord? I will give you a copy with debug messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Missing information Required information is missing ❌ Unconfirmed Bugs that were reported but yet to be replicatable
Projects
None yet
Development

No branches or pull requests

2 participants