Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ground_Engine: Add method to retrieve specific StratumProperty based on type #3452

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Ground_Engine: Add method to retrieve specific StratumProperty based on type #3452

wants to merge 2 commits into from

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Dec 23, 2024 •
edited
Loading

Issues addressed by this PR

Closes #3441

Test files

ConsolidateStrata test script

Changelog

  • Set default value for ConsolidateStrata() method to 2dp;
  • Add method to get IStratumProperty from a Stratum object by providing the type.

Additional comments

@peterjamesnugent
Remove unnecessary references for ground methods, add default value f…
982bcb0 
…or consolidation method and add method to get IStratumProperty
@peterjamesnugent peterjamesnugent added the type:feature New capability or enhancement label Dec 23, 2024
@peterjamesnugent peterjamesnugent self-assigned this Dec 23, 2024
@peterjamesnugent peterjamesnugent changed the title Add method to retrieve specific StratumProperty based on type Ground_Engine: Add method to retrieve specific StratumProperty based on type Dec 23, 2024
@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 24, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 24, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 24, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 24, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 24, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 24, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh IsakNaslundBh is a code owner

@FraserGreenroyd FraserGreenroyd Awaiting requested review from FraserGreenroyd FraserGreenroyd is a code owner

@jtrainor1 jtrainor1 Awaiting requested review from jtrainor1

At least 1 approving review is required to merge this pull request.

Assignees

@peterjamesnugent peterjamesnugent

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ground_Engine: Change default value for ConsolidateStrata method to 2dp
1 participant
@peterjamesnugent