Structure_Engine: flipping of bars fixed to take release into account #3447
Conversation
|
@peterjamesnugent @IsakNaslundBh when working on this one, I started thinking whether the orientation angle should not be negated too? Not entirely sure about it, but a part of me argued for that - happy for you to take over this and make an informed decision 👍 |
|
@BHoMBot check required |
|
@pawelbaran to confirm, the following actions are now queued:
|
|
@pawelbaran to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Happy that the script works as intended, minor change for the code if you think it's worth changing.
I have added a check for a horizontal bar, happy this works for the BarRelease.
As discussed offline, the orientational angle should update too, this needs to be set dependent on whether Bar is vertical if not:
- If
Baris vertical,newOrientationAngle = -orientationalAngle + pi() - If
Baris not vertical ,newOrientationAngle = -orientationAngle
I have added a bit in the script to show this.
pawelbaran
force-pushed
the
BHoM_Engine-#3446-FlipBarBug
branch
from
9157e9c to
7893070
Compare
Issues addressed by this PR
Closes #3446
Test files
On SharePoint
Changelog
Additional comments