Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Multiple Logic Requests #474

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

GCRA101
Copy link
Contributor

@GCRA101 GCRA101 commented Sep 17, 2024

Issues addressed by this PR

Closes #465

GH Script Canvas View

ETABS Toolkit now can allow to pull objects from ETABS based on FilterRequests, SelectedRequest and multiple LogicalRequests.

Test files

Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23474-AllowMultipleLogicRequests/[TestScript.gh](https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23474-AllowMultipleLogicRequests/TestScript.gh?csf=1&web=1&e=93kD0Q)?csf=1&web=1&e=93kD0Q
ETABS File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23474-AllowMultipleLogicRequests/Test%20ETABS%20Model.EDB?csf=1&web=1&e=IRUEie

Changelog

  • Added Read Method for FitlerRequests
  • Added Read Method for LogicalRequests (And, Or and Not)
  • Added Dynamic Comparer class allowing to compare IBHoMObjects based on ad-hoc criteria

@GCRA101 GCRA101 self-assigned this Sep 17, 2024
@GCRA101 GCRA101 added this to the BHoM 7.4 β MVP milestone Sep 17, 2024
@GCRA101 GCRA101 added the type:feature New capability or enhancement label Sep 17, 2024
@GCRA101
Copy link
Contributor Author

GCRA101 commented Sep 18, 2024

@Chrisshort92 , @peterjamesnugent , @IsakNaslundBh,

I've had the chance to finish the pull request for issue #465.

Also for this one, a pull request to be reviewed in the next sprint moving forward BHoM 7.4, not now ;)

Thanks guys! ;)

Chrisshort92
Chrisshort92 previously approved these changes Oct 14, 2024
Copy link

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality tested with files provided, all working as expected. Approved for merge

@Chrisshort92
Copy link

@BHoMBot Check required

Copy link

bhombot-ci bot commented Oct 14, 2024

@Chrisshort92 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 39 requests in the queue ahead of you.

Turned the getEtabsId() method name (from the DynamicComparer private class) into GetEtabsId(), based on BHoM method's naming convention.
@GCRA101
Copy link
Contributor Author

GCRA101 commented Oct 14, 2024

@Chrisshort92 , I've gone through the code compliance checks above and I've modified the code as per following commit 655b110
Turned the DynamicComparer from a private class within the _Read.cs file into a public class within the Types namespace.

@GCRA101
Copy link
Contributor Author

GCRA101 commented Oct 14, 2024

@BHoMBot Check required

Copy link

bhombot-ci bot commented Oct 14, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 85 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Oct 14, 2024

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Oct 14, 2024

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Oct 14, 2024

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Oct 14, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@Chrisshort92 Chrisshort92 self-requested a review October 14, 2024 13:31
Chrisshort92
Chrisshort92 previously approved these changes Oct 14, 2024
Copy link

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-tested code changes from @GCRA101, functionality working as expected, approved for merge.

@peterjamesnugent
Copy link
Member

@BHoMBot check compliance
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Oct 23, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check ready-to-merge

There are 19 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Oct 23, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Oct 23, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Oct 23, 2024

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@GCRA101
Copy link
Contributor Author

GCRA101 commented Oct 24, 2024

@peterjamesnugent,
added copyright header to DynamicComparer in latest commit.
9b081de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for Multiple Logical Requests
3 participants