-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Multiple Logic Requests #474
base: develop
Are you sure you want to change the base?
Conversation
…hsets of IBHoMObjects
… RECURSION AND REFLECTION
… adjust recursion calls
@Chrisshort92 , @peterjamesnugent , @IsakNaslundBh, I've had the chance to finish the pull request for issue #465. Also for this one, a pull request to be reviewed in the next sprint moving forward BHoM 7.4, not now ;) Thanks guys! ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality tested with files provided, all working as expected. Approved for merge
@BHoMBot Check required |
@Chrisshort92 to confirm, the following actions are now queued:
There are 39 requests in the queue ahead of you. |
Turned the getEtabsId() method name (from the DynamicComparer private class) into GetEtabsId(), based on BHoM method's naming convention.
@Chrisshort92 , I've gone through the code compliance checks above and I've modified the code as per following commit 655b110 |
@BHoMBot Check required |
@GCRA101 to confirm, the following actions are now queued:
There are 85 requests in the queue ahead of you. |
The check |
The check |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested code changes from @GCRA101, functionality working as expected, approved for merge.
@peterjamesnugent to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
The check |
The check |
The check |
@peterjamesnugent, |
Issues addressed by this PR
Closes #465
ETABS Toolkit now can allow to pull objects from ETABS based on FilterRequests, SelectedRequest and multiple LogicalRequests.
Test files
Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23474-AllowMultipleLogicRequests/[TestScript.gh](https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23474-AllowMultipleLogicRequests/TestScript.gh?csf=1&web=1&e=93kD0Q)?csf=1&web=1&e=93kD0Q
ETABS File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23474-AllowMultipleLogicRequests/Test%20ETABS%20Model.EDB?csf=1&web=1&e=IRUEie
Changelog