-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration of DelaunayTriangulate method to increase usage? #23
Comments
I think might be worth renaming/purposing the TriangleNet_Toolkit to something more generic like Mesh_Toolkit or Meshing_Toolkit. I think that way it's a more natural fit into other toolkits and will allow better factory patterns. I would probably keep separate from core (don't think that's what you were suggesting). |
Would agree with Robs suggestion, renaming it Mesh_Toolkit or Meshing_Toolkit, but still keeping it separate. 👍 |
Although there are no current development plans for the toolkit, the toolkit is named as such due to a previous decision that the toolkit be named after what it is wrapping (because it is providing the wrapper for the TriangleNet Nuget). This convention was followed on Clipper_Toolkit which wraps the Clipper nuget. So if we are changing that decision for the naming of this toolkit to further expand what occurs within it we might need to also consider Clipper_Toolkit for a similar discussion at some stage. |
Sounds good @FraserGreenroyd - worth considering. I think a neatly organised Mesh_Toolkit (I vote for mesh, not meshing - seems neater/broad) will be a fantastic place to gather a few wrappers as well as explicit code/methods. |
Following this conversation and BHoM/BHoM_Engine#1694, we thought with @al-fisher we'd like to prototype as following:
2b. We can discuss whether to move the simple
|
Closing this as the plan has now become even clearer:
|
Some further powerful uses of the
DelaunayTriangulate
method already in place and also planned - with some immediate use for creation ofBH.oM.Graphics.RenderMeshes
. #22As discussed there is potential for wider usage across other disciplines (in structures say with load take down based on a Voronoi dual of the Delaunay)
Would like to get thoughts on inclusion reference to this method in other engines or indeed migrating to avoid dependency on this repo if usage does expand.
We already have a couple of toolkits exploiting and we are planning a couple more.
This repo relies on a single Triangle NuGet
No urgency, in short term happy to continue - but worth a discussion for long term plans as this method has proven to be very useful.
Whether moving this from its own toolkit is a good idea might also be dependant on any further development plans, if there are any, for this toolkit as it stands?
@tg359 @FraserGreenroyd
@rwemay @IsakNaslundBh @alelom
@adecler @pawelbaran
The text was updated successfully, but these errors were encountered: