Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading of generics with recursion #186

Open
FraserGreenroyd opened this issue Jan 13, 2022 · 3 comments
Open

Upgrading of generics with recursion #186

FraserGreenroyd opened this issue Jan 13, 2022 · 3 comments
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@FraserGreenroyd
Copy link
Contributor

Following on from this commit as part of this PR, we need to strengthen up the Versioning for Generics. The implementation in the commit sufficed for the use case which was holding up several toolkits, so decision to merge as was, and raise this issue for future work (future being this milestone and not too far in the future) was agreed. This is the issue to capture that.

@FraserGreenroyd
Copy link
Contributor Author

@IsakNaslundBh @adecler how does this look/work now with our new serialiser/upgrade system? I'm presuming this is still required but figured best to double check!

@IsakNaslundBh
Copy link
Contributor

I think it most likely still could be relevant, but not sure. One that we almost would need to test.

Having a look at the particular commit referenced on the description of the issue, I ran in to similar issues with recursive generics for type creation whilst working with the serialiser engine, and implemented this method;

https://github.com/BHoM/BHoM_Engine/blob/5d4c70edd2c5823e651d38510190da86561b0764/BHoM_Engine/Create/Type/GenericType.cs#L153-L214

Might be more elegant ways to do it, but it works and don't think it is that inefficient, even though it is quite a few lines of code.

Potential to lift something like that over to the versioning toolkit as well, for the CleanTypeString method.

@FraserGreenroyd FraserGreenroyd removed their assignment Feb 21, 2024
@IsakNaslundBh
Copy link
Contributor

Once this is actioned, should make sure to cover the case added in #259 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

No branches or pull requests

3 participants