Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make digest an optional dependency once "weak dependencies" are available #204

Open
oconnor663 opened this issue Oct 22, 2021 · 1 comment

Comments

@oconnor663
Copy link
Member

Tracking issue: rust-lang/cargo#8832

The problem is that we have this line in Cargo.toml:

std = ["digest/std"]

That is, if you enable the std feature of this crate, then you also need the std feature of digest. The intention is that this should only matter if digest is enabled as an optional dependency. However, what it actually means is that enabling std always enables digest. This isn't a huge deal, because digest is small. But it does mean that digest isn't properly gated behind our traits-preview feature.

@elichai
Copy link
Contributor

elichai commented Jul 17, 2023

This can be closed now that #309 removed the digest/std dependency entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants