Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add openid login endpoints #144

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add openid login endpoints #144

wants to merge 1 commit into from

Conversation

LuiggiTenorioK
Copy link
Member

Related to issue #141

@LuiggiTenorioK LuiggiTenorioK linked an issue Nov 19, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.30%. Comparing base (cb68fba) to head (08c00c7).

Files with missing lines Patch % Lines
autosubmit_api/routers/v4/auth.py 15.38% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   72.38%   72.30%   -0.09%     
==========================================
  Files          86       86              
  Lines        7765     7782      +17     
==========================================
+ Hits         5621     5627       +6     
- Misses       2144     2155      +11     
Flag Coverage Δ
fast-tests 72.30% <42.10%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuiggiTenorioK LuiggiTenorioK marked this pull request as draft November 19, 2024 12:54
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, but looking good IMO!

@kinow
Copy link
Member

kinow commented Nov 19, 2024

(codecov is complaining, but not sure if that's testable)

@LuiggiTenorioK
Copy link
Member Author

LuiggiTenorioK commented Nov 19, 2024

TODO:

  • add tests
  • (optional) refactor to facilitate mantainance
  • update documentation to explain how to integrate it

@LuiggiTenorioK LuiggiTenorioK self-assigned this Nov 19, 2024
@LuiggiTenorioK
Copy link
Member Author

LuiggiTenorioK commented Nov 19, 2024

New endpoint pre-requirements:

Other references:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support OpenID connect authentication
3 participants