Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor db_jobdata #135

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Refactor db_jobdata #135

merged 2 commits into from
Nov 19, 2024

Conversation

LuiggiTenorioK
Copy link
Member

In GitLab by @LuiggiTenorioK on Nov 6, 2024, 16:32

In order to centralize the db managers as it is done in the Postgres branch we need to refactor the job_data module

Also, this solves the last issue we have with #73 where the graph data DB file is kept open when it is executed.

@LuiggiTenorioK LuiggiTenorioK self-assigned this Nov 12, 2024
@LuiggiTenorioK
Copy link
Member Author

In GitLab by @LuiggiTenorioK on Nov 11, 2024, 15:35

added 1 commit

Compare with previous version

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.93056% with 29 lines in your changes missing coverage. Please review.

Project coverage is 71.73%. Comparing base (2579e8b) to head (7a7dbd1).

Files with missing lines Patch % Lines
autosubmit_api/repositories/job_data.py 78.72% 20 Missing ⚠️
autosubmit_api/repositories/experiment_run.py 93.44% 4 Missing ⚠️
autosubmit_api/repositories/experiment.py 91.89% 3 Missing ⚠️
autosubmit_api/database/db_jobdata.py 94.73% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   70.28%   71.73%   +1.44%     
==========================================
  Files          82       86       +4     
  Lines        7932     7942      +10     
==========================================
+ Hits         5575     5697     +122     
+ Misses       2357     2245     -112
Flag Coverage Δ
fast-tests 71.73% <89.93%> (+1.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuiggiTenorioK LuiggiTenorioK linked an issue Nov 14, 2024 that may be closed by this pull request
Centralize all SQL operations in a repository module #142
Open
10 tasks
@LuiggiTenorioK
Copy link
Member Author

Since versions of Autosubmit < 3.13 are not meant to be supported and db_version is not set anymore, in JobDataStructure we can drop logic to handle different schemas.

@LuiggiTenorioK
Copy link
Member Author

This seems correctly refactored and well-tested. There are missing lines to test but those are from functions that are going to be used in the next refactor (e.g. Database Manager from the history module).

@LuiggiTenorioK LuiggiTenorioK merged commit b53e85f into main Nov 19, 2024
7 checks passed
@LuiggiTenorioK LuiggiTenorioK deleted the refactor-db-jobdata branch November 19, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LuiggiTenorioK LuiggiTenorioK

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Centralize all SQL operations in a repository module
2 participants
@LuiggiTenorioK @codecov-commenter